[web] Switch web-render option default to auto #23090

ferhatb · 2020-12-15T20:50:18Z

Description

Switches web-render to default to auto detect. On desktop flutter web will start using canvas kit by default, on mobile html will be used to render. Users can still override by -web-renderer=html or canvaskit.

See public doc https://docs.google.com/document/d/1aY0iU16wf_sdT7nwfpjgT-IatHNfF3slTiYHKmxcIog/edit

After this change if you encounter issues please see https://flutter.dev/docs/development/tools/web-renderers to switch to html (prior default) or canvaskit modes explicitely.

Related Issues

flutter/flutter#72377

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [contributor guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [C++, Objective-C, Java style guides] for the engine.
I read the [tree hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

I have submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

flutter-dashboard · 2020-12-15T20:50:20Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

yjbanov

yjbanov · 2020-12-15T21:07:04Z

lib/web_ui/lib/src/engine/canvaskit/initialization.dart

 /// Otherwise, it would be false.
 const bool _autoDetect =
-    bool.fromEnvironment('FLUTTER_WEB_AUTO_DETECT', defaultValue: false);
+    bool.fromEnvironment('FLUTTER_WEB_AUTO_DETECT', defaultValue: true);


Do we also need to change something in the tool?

nturgut

LGTM. Thanks!

fanchou · 2020-12-16T15:27:18Z

Predictably, there will be a significant increase in the number of questions about why text can't be displayed. Maybe we should wait until #23096 land.😃

ferhatb · 2020-12-16T17:35:45Z

@fanchou , @mariamhas : Thanks for message. Its exactly what we are doing. That fix is about to land so we are getting this ready to make sure CI and other systems are ready.

…e#23090)

This reverts commit 50e7d89.

) This reverts commit 50e7d89.

…e#23090)

* c608b07 bump fuchsia toolchain to clang-12 (flutter/engine#23067) * 8a3e9a2 fix crash in FontCollection::init() when FontFamily is empty (flutter/engine#23019) * 95ba5ca Roll Skia from 6f31e27f1e29 to 85fa75616dfe (7 revisions) (flutter/engine#23118) * 50e7d89 [web] Switch web-render option default to auto (flutter/engine#23090) * 8854520 Roll Skia from 85fa75616dfe to d6f2338ab194 (3 revisions) (flutter/engine#23119) * acad21c [web] Tests for rich paragraph DOM (flutter/engine#23097) * 27ebbc4 Rename PointerState.isDown as per style guide (flutter/engine#23120) * 19950f5 [web] Rich paragraph getBoxesForRange (flutter/engine#23098) * 581acbe Roll Skia from d6f2338ab194 to 1d89532d5988 (1 revision) (flutter/engine#23122) * 540b191 Roll Fuchsia Mac SDK from acylwa3i4... to chLTYsKMR... (flutter/engine#23125) * 3b52edf Roll Skia from 1d89532d5988 to 7839f66540b6 (1 revision) (flutter/engine#23126) * 6b25350 Roll Fuchsia Linux SDK from TIKHoiQyP... to wu6yV-_BL... (flutter/engine#23127) * 9c72085 Roll Skia from 7839f66540b6 to 20f1b3462878 (1 revision) (flutter/engine#23129) * ee323d0 Roll Skia from 20f1b3462878 to 995f0366bd21 (2 revisions) (flutter/engine#23132) * 625aa69 Roll Skia from 995f0366bd21 to b64da3907f76 (1 revision) (flutter/engine#23135) * affc421 Roll Skia from b64da3907f76 to 81da68af2ecf (7 revisions) (flutter/engine#23142) * 9a6a31e Roll Fuchsia Mac SDK from chLTYsKMR... to RDUxjnng0... (flutter/engine#23143) * 78657ed Added golden test to make sure that spawn engines work. (flutter/engine#23066) * bb9cac2 Roll Fuchsia Linux SDK from wu6yV-_BL... to _l04etgVd... (flutter/engine#23145) * 51c9ae9 Add --strict_null_safety_checks to the Dart flag allowlist (flutter/engine#23144) * 76310c4 Add missing sdk constriant in pubspec.yaml files. (flutter/engine#23124) * 6e54f0d [fuchsia] Add wrapper for zx_clock_get_monotonic. (flutter/engine#23128) * ade75e0 [web] Rich paragraph getPositionForOffset (flutter/engine#23133) * 2ef2c86 Fix engine in preparation for implementing dart-lang/language#1274 (flutter/engine#23131) * 9384324 Update android_lint deps (flutter/engine#23151) * ea4bb2a Roll Skia from 81da68af2ecf to 7b920446a8fc (14 revisions) (flutter/engine#23152) * 4b5e4e6 Make it easier to turn on Xcode symlinks (flutter/engine#23150) * 325f069 Roll fuchsia toolchain (flutter/engine#23155) * 05704d3 Use include for C/C++ headers in darwin/macos (flutter/engine#23035) * 8d3d69b Turned no malloc scribble and randomized the tests. (flutter/engine#23014) * 418cc48 Fix macOS crash when modifier keys pressed. (flutter/engine#23154) * a8c360d Update FlutterPlatformViewsTests (flutter/engine#23158) * d941aef [web] Rich text painting on bitmap canvas (flutter/engine#23136) * 67cb0f3 Revert "[web] Switch web-render option default to auto (#23090)" (flutter/engine#23161) * c4b48c5 Roll Skia from 7b920446a8fc to dfc880bd9ba0 (14 revisions) (flutter/engine#23164) * de1de9d Disable FlutterPluginAppLifeCycleDelegateTest testWillResignActive (flutter/engine#23166)

…" (flutter#23161) This reverts commit 50e7d89.

Switch web-render option default to auto

27fbbdc

ferhatb requested a review from yjbanov December 15, 2020 20:50

google-cla bot added the cla: yes label Dec 15, 2020

yjbanov approved these changes Dec 15, 2020

View reviewed changes

Update test runner

ad695a2

nturgut approved these changes Dec 15, 2020

View reviewed changes

ferhatb merged commit 50e7d89 into flutter:master Dec 17, 2020

engine-flutter-autoroll mentioned this pull request Dec 17, 2020

Roll Engine from fd6b409f950b to affc4216fe08 (16 revisions) flutter/flutter#72529

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

b95746a

…e#23090)

engine-flutter-autoroll mentioned this pull request Dec 17, 2020

Roll Engine from fd6b409f950b to bb9cac29a030 (19 revisions) flutter/flutter#72536

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

a7bb6b8

…e#23090)

engine-flutter-autoroll mentioned this pull request Dec 17, 2020

Roll Engine from fd6b409f950b to 76310c4264df (21 revisions) flutter/flutter#72547

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

a5e5241

…e#23090)

engine-flutter-autoroll mentioned this pull request Dec 17, 2020

Roll Engine from fd6b409f950b to 9384324cc15c (25 revisions) flutter/flutter#72556

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

f0fe20a

…e#23090)

engine-flutter-autoroll mentioned this pull request Dec 17, 2020

Roll Engine from fd6b409f950b to 4b5e4e60578b (27 revisions) flutter/flutter#72564

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

3cf552e

…e#23090)

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Engine from fd6b409f950b to 8d3d69b6b0f9 (30 revisions) flutter/flutter#72566

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

6a952bd

…e#23090)

zanderso added a commit that referenced this pull request Dec 18, 2020

Revert "[web] Switch web-render option default to auto (#23090)"

b91f5bd

This reverts commit 50e7d89.

zanderso mentioned this pull request Dec 18, 2020

Revert "[web] Switch web-render option default to auto" #23161

Merged

zanderso added a commit that referenced this pull request Dec 18, 2020

Revert "[web] Switch web-render option default to auto (#23090)" (#23161

67cb0f3

) This reverts commit 50e7d89.

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Engine from fd6b409f950b to 8d3d69b6b0f9 (30 revisions) flutter/flutter#72575

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

88555e8

…e#23090)

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Engine from fd6b409f950b to a8c360dc241a (32 revisions) flutter/flutter#72580

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

c886008

…e#23090)

engine-flutter-autoroll mentioned this pull request Dec 18, 2020

Roll Engine from fd6b409f950b to de1de9d44f58 (36 revisions) flutter/flutter#72584

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2020

50e7d89 [web] Switch web-render option default to auto (flutter/engin…

cc668b6

…e#23090)

nturgut mentioned this pull request Dec 18, 2020

make sure tests and benchmarks use correct backend flutter/flutter#72628

Merged

13 tasks

ferhatb mentioned this pull request Dec 21, 2020

[web] Reland - Switch web-render option default to auto #23214

Closed

13 tasks

ferhatb mentioned this pull request Dec 28, 2020

[web] Reland - Switch web-render option default to auto #23313

Merged

13 tasks

gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 5, 2021

[web] Switch web-render option default to auto (flutter#23090)

8abed7b

gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 5, 2021

Revert "[web] Switch web-render option default to auto (flutter#23090)…

c05d65d

…" (flutter#23161) This reverts commit 50e7d89.

ferhatb mentioned this pull request Jan 6, 2021

[web] Reland - Switch web-render option default to auto #23454

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[web] Switch web-render option default to auto #23090

[web] Switch web-render option default to auto #23090

Uh oh!

ferhatb commented Dec 15, 2020 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Dec 15, 2020

Uh oh!

yjbanov left a comment

Uh oh!

yjbanov Dec 15, 2020

Uh oh!

nturgut left a comment

Uh oh!

fanchou commented Dec 16, 2020

Uh oh!

ferhatb commented Dec 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[web] Switch web-render option default to auto #23090

[web] Switch web-render option default to auto #23090

Uh oh!

Conversation

ferhatb commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Reviewer Checklist

Breaking Change

Uh oh!

flutter-dashboard bot commented Dec 15, 2020

Uh oh!

yjbanov left a comment

Choose a reason for hiding this comment

Uh oh!

yjbanov Dec 15, 2020

Choose a reason for hiding this comment

Uh oh!

nturgut left a comment

Choose a reason for hiding this comment

Uh oh!

fanchou commented Dec 16, 2020

Uh oh!

ferhatb commented Dec 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ferhatb commented Dec 15, 2020 •

edited

Loading