Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Dec 11, 2020

See flutter/buildroot#417

This helps make GOMA work on macOS related builds.

See flutter/buildroot#417

This helps make GOMA work on macOS related builds.
@dnfield dnfield requested a review from zanderso December 11, 2020 21:54
@google-cla google-cla bot added the cla: yes label Dec 11, 2020
@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 11, 2020
@dnfield
Copy link
Contributor Author

dnfield commented Dec 11, 2020

@godofredoc FYI

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Dec 11, 2020
@dnfield
Copy link
Contributor Author

dnfield commented Dec 12, 2020

This needs flutter/buildroot#418 because of some trickery we do to link in XCTest.

@dnfield dnfield changed the title Roll buildroot to flutter/buildroot@137ddfc670a190b478dfdd3e94ced1fec2b6131f Roll buildroot to flutter/buildroot@15519113ddafd2e6bd37df39d2284e76cad95550 Dec 12, 2020
@dnfield dnfield changed the title Roll buildroot to flutter/buildroot@15519113ddafd2e6bd37df39d2284e76cad95550 Roll buildroot to flutter/buildroot@64bf32094b19bfecc2515aedb7e130f7ba15d297 Dec 14, 2020
@dnfield dnfield merged commit 89d64da into master Dec 15, 2020
@dnfield dnfield deleted the dnfield-patch-1 branch December 15, 2020 16:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Dec 15, 2020
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 5, 2021
* Roll buildroot to flutter/buildroot@64bf320

See flutter/buildroot#417

This helps make GOMA work on macOS related builds.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants