This repository was archived by the owner on Feb 25, 2025. It is now read-only.
re-enable pointer events inside platform views #22874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
force-pushed
the
ck-platform-views
branch
from
42de22d to
cca06a9
Compare
yjbanov
force-pushed
the
ck-platform-views
branch
from
cca06a9 to
f94f282
Compare
ditman
approved these changes
Dec 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2020
mdebbar
reviewed
Dec 7, 2020
|
|
||
| test('embeds interactive platform views', () async { | ||
| ui.platformViewRegistry.registerViewFactory( | ||
| 'test-platform-view', |
There was a problem hiding this comment.
This worries me a bit because there's no way to clean it up. Tests may conflict with each other since factory names are global.
This was referenced Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-enable pointer events inside platform views in CanvasKit.
Related Issues
Fixes flutter/flutter#69124
Tests
I added the following tests: TBD