Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 21, 2020

Description

Create Flutter.xcframework as part of the recipe packaging script.

Next steps

  • Update the recipe to upload the generated Flutter.xcframework in that recipe to publish Flutter.xcframework as a downloadable engine artifact.
  • Add it to the codesigning script.
  • Update flutter tooling to use Flutter.xcframework.

Related Issues

Local engine support part of flutter/flutter#60109, which is a dependency to support macOS ARM simulators flutter/flutter#64502

Tests

The create_xcframework.py change is tested via the Scenario app, which embeds the Flutter.xcframework from the out directory and won't compile if something goes wrong there.

The create_xcframework.py output is only used in the recipe, and tested there. There are also many framework tests validating framework validation, bitcode, symbol stripping, etc, and this will be tested there when the tool adopts.

Checklist

  • I read the [contributor guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [C++, Objective-C, Java style guides] for the engine.
  • I read the [tree hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

  • I have submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman self-assigned this Nov 21, 2020
@google-cla google-cla bot added the cla: yes label Nov 21, 2020
@jmagman jmagman marked this pull request as ready for review November 22, 2020 01:42
@jmagman jmagman requested a review from dnfield November 22, 2020 01:42
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 23, 2020
@fluttergithubbot fluttergithubbot merged commit b1c7553 into flutter:master Nov 23, 2020
@jmagman jmagman deleted the xcframework branch November 23, 2020 18:14
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants