Add SDK licenses to DEPS #22551
Add SDK licenses to DEPS #22551
Conversation
DEPS
Outdated
| 'packages': [ | ||
| { | ||
| 'package': 'flutter/android/sdk/licenses', | ||
| 'version': 'last_updated:2020-11-16T13:56:24-0800' |
There was a problem hiding this comment.
Should we tag it with a ref or tag instead of using the date? E.g something more relevant to the state of the package?
There was a problem hiding this comment.
if we believe we need only one package in prod at a time then we add a ref release to the cipd package and use it here.
godofredoc
left a comment
godofredoc
left a comment
There was a problem hiding this comment.
if other parts on the engine use last_updated tag then LGTM
blasten
force-pushed
the
android_licenses
branch
from
5b98846 to
3902f51
Compare
|
The breaks the Flutter HHH build on the Dart CI and the Flutter build on the Dart CQ. failed to resolve flutter_internal/android/sdk/licenses@latest (line 28): prefix "flutter_internal/android/sdk/licenses" doesn't exist or "user:[email protected]" is not allowed to see it, run
I presume this is not only a problem to the Dart CI and CQ, but everyone trying to do |
|
This also seems to be causing all rollers into flutter/engine to fail: https://bugs.chromium.org/p/skia/issues/detail?id=10961 |
* Update 1.24 engine to use Dart 2.12.0-29.10.beta * Add SDK licenses to DEPS (#22551) * Use flutter public package for the time being (#22560) Co-authored-by: Emmanuel Garcia <[email protected]>
Co-authored-by: Emmanuel Garcia <[email protected]>
4 participants
Provides Android SDK licenses, so the step can be removed from the recipes.
Related Issues
flutter/flutter#70633