This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Android Text Input] Make the editing state listenable and allow batch edits " #22434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
approved these changes
Nov 12, 2020
LongCatIsLooong
added
the
waiting for tree to go green
LongCatIsLooong
added a commit
to LongCatIsLooong/engine
that referenced
this pull request
Nov 12, 2020
batch edits (flutter#21534)", reverted in (flutter#22434) This reverts commit 23b6310.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
…e and allow batch edits (flutter#21534)" (flutter/engine#22434)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
…e and allow batch edits (flutter#21534)" (flutter/engine#22434)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
…e and allow batch edits (flutter#21534)" (flutter/engine#22434)
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/173060336. Reverts #21534 just realized the selection handling was problematic.
selectionStart > selectionEndshould be valid.