Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@lqs
Copy link

@lqs lqs commented Oct 13, 2020

Description

When using Image.network() with a corrupted image file, flutter engine crashes.
This pull request attempts to fix this issue.

This is an example of the corrupted image:
https://user-images.githubusercontent.com/501269/95818771-335d4b00-0d57-11eb-8b6a-97df7c54d5c5.jpg

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member

Thanks. This patch is identical to #21891.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants