This repository was archived by the owner on Feb 25, 2025. It is now read-only.
isCloneOf for Image #21371
Merged
isCloneOf for Image #21371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
Sep 24, 2020
lib/ui/painting.dart
Outdated
| } | ||
|
|
||
| /// Returns true if `other` shares the same underlying image memory as this, | ||
| /// even if this or `other` is [dispose]d. |
There was a problem hiding this comment.
might be worth referring to clone in these docs
dnfield
added
the
waiting for tree to go green
zanderso
approved these changes
Sep 24, 2020
|
The tree looks green. Landing this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #21057
The framework wants to compare images to avoid potentially expensive logic when setting an image. What it really wants to know is if the underlying image reference is the same. This makes that possible.