Fix iOS platform view's mask view blocking touch events. #21286

cyanglaz · 2020-09-19T20:08:57Z

Description

The iOS platform view's mask view are sometimes physically added to the view hierarchy which resulting blocking the touch events. It is not documented and I'm not sure what is iOS's intention of doing that. (Could be an iOS bug) The mask view is only for determining the alpha channel for the platform view (for clipping), and we can always ignore the touch events.

Related Issues

Fixes flutter/flutter#66044

Tests

I added the following tests:

testGestureWithMaskViewBlockingPlatformView
Also updated the PlatformViewForTouchIOSScenario to produce a second frame which reproduces this issue.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

blasten · 2020-09-21T16:29:41Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm

+// // In some scenarios, when we add this view as a maskView of the ChildClippingView, iOS added
+// this view as a
+// // subview of the ChildClippingView. This results this view blocking touch events on the
+// ChildClippingView.
+// // So we should always ignore any touch events sent to this view.
+// // See https://github.com/flutter/flutter/issues/66044


nit: comment needs to be re-formatted.

done! Thanks!

blasten · 2020-09-21T16:34:27Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewGestureRecognizerTests.m

+                        @"-gestureTouchesBegan-gestureTouchesEnded-platformViewTapped");
+}
+
+- (void)testGestureWithMaskViewBlockingPlatformView {


does this test fail if you comment out FlutterPlatformViews_Internal.mm #L99-102?

blasten · 2020-09-21T16:44:18Z

testing/scenario_app/lib/src/platform_view.dart

+  @override
+  void onDrawFrame() {
+    // Some iOS gesture recognizers bugs are introduced in the second frame (with a different platform view rect) after laying out the platform view.
+    // So in this test, we pop 2 frames to ensure that we cover those cases.


Done, updated to load

blasten · 2020-09-21T17:00:25Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm

 }

+// In some scenarios, when we add this view as a maskView of the ChildClippingView, iOS added
+// this view as a


do you want to cut sentences like this, or does it make sense to manually break the lines below the limit so the autoformater doesn't do something weird?

Hmm this is weird. Fixed

blasten

LGTM

…to platform_view_gesture

…tter/engine#21286)

* Update 1.22 engine to use Dart 2.10.0-110.5.beta * Dark mode friendly iOS debugging message (#21277) * Update FlutterViewController.mm (#21362) * Tweaked the label here a little for style ("apps", not "application" -- plural and shorter); and "launching" rather than "re-launching"? * Fix iOS platform view's mask view blocking touch events. (#21286) * Disconnect the view's AndroidKeyProcessor when detaching from the engine (#21307) * Remove extraneous window inset call on IME animation (#21213) * Retain the WindowInsetsAnimation callback if code shrinking is enabled (#21330) Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Tim Sneath <[email protected]> Co-authored-by: Chris Yang <[email protected]> Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Gary Qian <[email protected]>

Chris Yang added 2 commits September 19, 2020 10:34

fix

eae57ee

fix mask view blocking gestures

cd1fb2a

flutter-dashboard bot added the platform-ios label Sep 19, 2020

googlebot added the cla: yes label Sep 19, 2020

cyanglaz requested review from amirh and blasten September 19, 2020 20:09

This was referenced Sep 19, 2020

[webview_flutter] Gesture regression on iOS from 1.20.2 flutter/flutter#66044

Closed

Platform views in Add2App (iOS only) are broken as a result of https://github.com/flutter/engine/pull/20050 flutter/flutter#66026

Closed

blasten reviewed Sep 21, 2020

View reviewed changes

review

28dfa48

blasten reviewed Sep 21, 2020

View reviewed changes

Update platform_view.dart

e937562

blasten reviewed Sep 21, 2020

View reviewed changes

blasten approved these changes Sep 21, 2020

View reviewed changes

Chris Yang added 2 commits September 21, 2020 10:07

fix comment format

e41e911

Merge branch 'platform_view_gesture' of github.com:cyanglaz/engine in…

84b67ac

…to platform_view_gesture

cyanglaz merged commit 678653b into flutter:master Sep 21, 2020

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 678653bfb688 (16 revisions) flutter/flutter#66304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

774b195

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 978371fd1ea1 (19 revisions) flutter/flutter#66309

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

73cde13

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 6a6d6d759312 (22 revisions) flutter/flutter#66313

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

24f4179

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 1ee3364df1c0 (24 revisions) flutter/flutter#66329

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

1df165f

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to ecedc854c473 (27 revisions) flutter/flutter#66337

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

f446e9e

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to c73732616b0b (28 revisions) flutter/flutter#66340

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

14d3319

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 98cdb7d82d35 (29 revisions) flutter/flutter#66346

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

82fb656

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 83c9d103edd4 (30 revisions) flutter/flutter#66353

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

bdf37aa

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 24df09ddd126 (31 revisions) flutter/flutter#66362

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

b032003

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to fcb56ec20309 (32 revisions) flutter/flutter#66365

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

284b31f

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 88e53777d1aa (34 revisions) flutter/flutter#66371

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

72b4d44

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to c0aa47e7fe60 (35 revisions) flutter/flutter#66378

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

593b9c8

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 84d50d71d20b (36 revisions) flutter/flutter#66388

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

b4733a2

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to 69e24105951e (40 revisions) flutter/flutter#66396

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

38f654a

…tter/engine#21286)

engine-flutter-autoroll mentioned this pull request Sep 22, 2020

Roll Engine from 4b8477d11573 to c62d6652992b (44 revisions) flutter/flutter#66398

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020

678653b Fix iOS platform view's mask view blocking touch events. (flu…

c8a3338

…tter/engine#21286)

cyanglaz mentioned this pull request Oct 26, 2020

[Google-maps-flutter] UiKitView become unresponsive after interacting with image picker camera flutter/flutter#65361

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix iOS platform view's mask view blocking touch events. #21286

Fix iOS platform view's mask view blocking touch events. #21286

Uh oh!

cyanglaz commented Sep 19, 2020 •

edited

Loading

Uh oh!

blasten Sep 21, 2020

Uh oh!

cyanglaz Sep 21, 2020

Uh oh!

blasten Sep 21, 2020

Uh oh!

cyanglaz Sep 21, 2020

Uh oh!

blasten Sep 21, 2020

Uh oh!

cyanglaz Sep 21, 2020

Uh oh!

blasten Sep 21, 2020

Uh oh!

cyanglaz Sep 21, 2020

Uh oh!

blasten left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix iOS platform view's mask view blocking touch events. #21286

Fix iOS platform view's mask view blocking touch events. #21286

Uh oh!

Conversation

cyanglaz commented Sep 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cyanglaz commented Sep 19, 2020 •

edited

Loading