Revert "Enable lazy-async-stacks by-default in all modes (Take 3)"

[zanderso]

Reverts #20895

Still some test failures on Windows:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8869626383922720992/+/steps/run_test.dart_for_tool_tests_shard_and_subshard_integration/0/stdout?format=raw

[zanderso]

Landing revert before presubmits finish to help unblock the roll to the framework.

[mkustermann]

After quite some debugging we believe to have found out what the root cause of this windows failure is:

Flutter testing infrastructure uses package:test and package:stack_trace. The latter does not correctly handle <asynchronous gap> markers - more specifically it assumes there are only such gaps between frames. If there is such a gap at the very last frame (for which no caller was found) it will treat it as a real frame. It will then treat this as a file path - which fails on windows due to the < which cannot appear in file names:

Unsupported operation: Illegal character in path: <asynchronous
#0      _Uri._checkWindowsPathReservedCharacters (dart:core/uri.dart:1734:11)
#1      _Uri._toWindowsFilePath (dart:core/uri.dart:2745:7)
#2      _Uri.toFilePath (dart:core/uri.dart:2720:38)
#3      JsonReporter._addFrameInfo (package:test_core/src/runner/reporter/json.dart:313:21)
#4      JsonReporter._onTestStarted (package:test_core/src/runner/reporter/json.dart:136:15)
#5      _rootRunUnary (dart:async/zone.dart:1206:13)
...
#19     LiveSuiteController.reportLiveTest (package:test_core/src/runner/live_suite_controller.dart:147:30)
#20     Engine._runLiveTest (package:test_core/src/runner/engine.dart:377:21)
<asynchronous suspension>
#21     Engine._runGroup (package:test_core/src/runner/engine.dart:330:19)
#22     Engine.run.<anonymous closure>.<anonymous closure> (package:test_core/src/runner/engine.dart:275:17)
<asynchronous suspension>
#23     Engine.run.<anonymous closure>.<anonymous closure> (package:test_core/src/runner/engine.dart)
#24     Engine.run.<anonymous closure> (package:test_core/src/runner/engine.dart:281:8)
#25     _rootRunUnary (dart:async/zone.dart:1198:47)
#26     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
...

This failure in the test framework then causes cascading failures - such as a racy shutdown which causes the compilation service is not available error.

@cskau-g Will try to address this in upstream package:stack_trace and then we'll re-land this CL.

@zanderso In the future, please try to CC authors when reverting a PR - we actually only noticed this over a month later (gerrit puts people from original CL automatically on CC on a revert, unfortunately it don't seem like this on github)

[zanderso]

Whoops. Sorry about that. I thought github would send a notification to folks on the reverted PR without the CC on the revert PR, but it looks like I was wrong.