This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Log the results when ShellTest.Screenshot fails #20932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Sep 1, 2020
shell/common/shell_unittests.cc
Outdated
| sk_sp<SkData> screenshot_data = screenshot_future.get().data; | ||
| if (!reference_data->equals(screenshot_data.get())) { | ||
| LogSkData(reference_data, "reference"); | ||
| LogSkData(reference_data, "screenshot"); |
Contributor
There was a problem hiding this comment.
Suggested change
| LogSkData(reference_data, "screenshot"); | |
| LogSkData(screenshot_data, "screenshot"); |
dnfield
reviewed
Sep 1, 2020
shell/common/shell_unittests.cc
Outdated
| LogSkData(reference_data, "reference"); | ||
| LogSkData(reference_data, "screenshot"); | ||
| } | ||
| ASSERT_TRUE(reference_data->equals(screenshot_data.get())); |
Contributor
There was a problem hiding this comment.
nit: can we just do something like ASSERT_TRUE(false) in the if block above to avoid doing the comparison twice?
Contributor
There was a problem hiding this comment.
We should then drop this line
jason-simmons
force-pushed
the
bug_65026_log
branch
2 times, most recently
from
360be7b to
1c08a20
Compare
zanderso
approved these changes
Sep 1, 2020
jason-simmons
force-pushed
the
bug_65026_log
branch
from
1c08a20 to
821aed3
Compare
This test has been flaky on LUCI recently. See flutter/flutter#65026
jason-simmons
force-pushed
the
bug_65026_log
branch
from
821aed3 to
465942c
Compare
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been flaky on LUCI recently.
See flutter/flutter#65026