Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Aug 25, 2020

Description

When FlutterActivity/Fragment access bundle inferred parameters without initializing FlutterLoader, they crash. Let's fix that temporarily until #64458 is fixed.

Related Issues

flutter/flutter#64458

Tests

FlutterLoader does not have any tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

…ccess bundle inferred parameters without initializing FlutterLoader
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@xster
Copy link
Member

xster commented Aug 26, 2020

Let me do it in #20769 (writing test).

Letting getAppBundlePath be not package visibility was a mistake I think since the only consumer is the FlutterActivityAndFragmentDelegate which always consumes it at the right time.

Defer everything until later.

@mehmetf
Copy link
Contributor Author

mehmetf commented Aug 26, 2020

Sounds good.

@mehmetf mehmetf closed this Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants