This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add a golden scenario test for fallback font rendering on iOS #20687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Aug 21, 2020
| import 'scenario.dart'; | ||
|
|
||
| /// Tries to draw some text in a bogus font. Should end up drawing in the | ||
| /// system default font. |
There was a problem hiding this comment.
Can we add a platform view that does the same in the same view?
That way, it'll be very clear when updating goldens whether or not the change is legit.
|
@xster Are you making progress on this? Can you fix the remaining presub and land this? |
|
Sorry, had to push 1.22 stuff first. I'll loop back to this next week. |
|
Can this land now? |
xster
force-pushed
the
font-fallback-golden
branch
from
20cede8 to
7906b12
Compare
|
Some presubmits are still failing. Kicked them again. |
|
Closing this stale PR. Feel free to reopen when progress can be made. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat related to flutter/flutter#60013. If user specifies a font that doesn't exist, it should properly fallback to the SF font and render it correctly. Needs #20557 to render the right font.
@blasten I'm removing those iPhone SE images as previously discussed. Pull a modular golden test part out of the platform view stuff.