-
Notifications
You must be signed in to change notification settings - Fork 6k
Enable ios platform view by default #20671
Enable ios platform view by default #20671
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
blasten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
| return nullptr; | ||
| } | ||
|
|
||
| ExternalViewEmbedder* IOSSurface::GetExternalViewEmbedderIfEnabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we just remove GetExternalViewEmbedderIfEnabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the common method that's called by all the different surface implementations. So it is better to keep it there. Or we can update the method name (removing the IfEnabled)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. GetExternalViewEmbedder mirrors Android's.
Description
An app that uses platform view (webview, googlemap, etc) doesn't need to add the
io.flutter.embedded_views_previewflag on their info.plist after this patch lands.Related Issues
Fixes flutter/flutter#64270
Tests
I added the following tests:
Updated the scenario app to not include the flag and the tests should still pass
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.