-
Notifications
You must be signed in to change notification settings - Fork 6k
Add null checks for CanvasElement attributes #20580
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Check out the "format_and_dart_test" Looks like you are using |
|
This is strange. In my local build, when I add the aforementioned Dart SDK patch to third_party and attempt to Although, now when I run |
|
Paging @yjbanov, he knows more about web_ui and the current state of the dart null safety code. |
Changes in processing compatibility info in dart:html requires these getters to be null-checked.
8103ebe to
553ef88
Compare
|
Windows host engine failure looks unrelated (infra flake even). Merging. |
Changes in processing compatibility info in dart:html requires
these getters to be null-checked.
Description
CanvasElementattributes will be changed to be potentially nullable (see https://dart-review.googlesource.com/c/sdk/+/155844), so they are null-checked.Related Issues
No new issue for this, but related to the original process in dart-lang/sdk#41905.
Tests
No tests added.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read [handling breaking changes].