This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add virtual destructors to ByteStream* #20417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renyou
approved these changes
Aug 11, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 11, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2020
renyou
pushed a commit
to renyou/engine
that referenced
this pull request
Aug 13, 2020
renyou
added a commit
that referenced
this pull request
Aug 13, 2020
* Add virtual destructors to ByteStream* (#20417) * Fix broken symbols on Fuchsia embedder (#20459) See: b/163653659 Co-authored-by: stuartmorgan <[email protected]> Co-authored-by: David Worsham <[email protected]>
renyou
added a commit
that referenced
this pull request
Aug 14, 2020
* Add virtual destructors to ByteStream* (#20417) * Fix broken symbols on Fuchsia embedder (#20459) See: b/163653659 * Fix the legacy EncodableValue codepaths (#20501) A recent refactoring broke the USE_LEGACY_ENCODABLE_VALUE codepath in standard_codec.cc, which went unnoticed since it wasn't being compiled. This fixes the breakage, and also adds a temporary minimal unit test target that ensures that all the USE_LEGACY_ENCODABLE_VALUE paths are being compiled. Co-authored-by: stuartmorgan <[email protected]> Co-authored-by: David Worsham <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the lack of virtual destructors in the ByteStream* interfaces classes in the C++ client wrapper.
Related Issues
None.
Tests
I added the following tests: None; evaluation of warning flags will follow shortly.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.