-
Notifications
You must be signed in to change notification settings - Fork 6k
add information collection for safari bots #20123
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
lib/web_ui/dev/test_runner.dart
Outdated
/// Collect information on the bot. | ||
final MacOSInfo macOsInfo = new MacOSInfo(); | ||
await macOsInfo.collectInformation(); | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell if this is intentional or a remnant from debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional. Safari tests are still failing on some method version combinations. I'm adding this code to collect information on the bots. The return with true without running the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added isLUCI check, so we can still use felt test --browser=safari
locally :)
} | ||
|
||
/// Print all the defaults in the system related to Safari. | ||
Future<void> _printSafariDefaults() async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdebbar I added this part too. I thought some defaults such as DefaultBrowserPromptingState
might be related to test flakes. Therefore it would be valuable information once we start running the tests.
Future<void> printInformation() async { | ||
await _printSafaridApplications(); | ||
await _printSafariDefaults(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any chance of exceptions being thrown here? Let's guard against them so we don't fail our tests unnecessarily. Maybe something like:
Future<void> printInformation() async {
try {
await _printSafariApplications();
} catch (error) {
print('Error thrown while getting Safari Applications: $error');
}
try {
await _printSafariDefaults();
} catch (error) {
print('Error thrown while getting Safari defaults: $error');
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, makes sense, since these might be different OS'es the tools might also be different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added the user limits, since we added try-catch it shouldn't be a problem even if we get a permission error.
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101) * b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102) * 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104) * 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270) * d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105) * 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108) * 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109) * ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110) * f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067) * 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113) * 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114) * 49a40fa Enabled linting on engine.cc (flutter/engine#19981) * b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092) * 145ef60 Remove confusing logs (flutter/engine#20121) * 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126) * ec9e17c Roll zlib (flutter/engine#20119) * f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924) * 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968) * 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129) * 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133) * d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132) * 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125) * 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135) * 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136) * b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137) * adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138) * 941c442 Add ALERT SoundType enum value (flutter/engine#20139) * 19368ef Fix dartdocs of dart:ui (flutter/engine#20140) * 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141) * 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143) * 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146) * da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147) * 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148) * 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107) * 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105) * 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150) * 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152) * e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153) * f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127) * 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154) * 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155) * e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990) * f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158) * e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794) * c134e16 add information collection for safari bots (flutter/engine#20123) * ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (#19270)" (flutter/engine#20165) * 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161) * a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988) * 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101) * b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102) * 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104) * 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270) * d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105) * 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108) * 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109) * ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110) * f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067) * 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113) * 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114) * 49a40fa Enabled linting on engine.cc (flutter/engine#19981) * b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092) * 145ef60 Remove confusing logs (flutter/engine#20121) * 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126) * ec9e17c Roll zlib (flutter/engine#20119) * f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924) * 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968) * 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129) * 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133) * d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132) * 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125) * 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135) * 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136) * b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137) * adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138) * 941c442 Add ALERT SoundType enum value (flutter/engine#20139) * 19368ef Fix dartdocs of dart:ui (flutter/engine#20140) * 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141) * 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143) * 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146) * da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147) * 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148) * 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107) * 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105) * 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150) * 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152) * e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153) * f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127) * 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154) * 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155) * e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990) * f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158) * e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794) * c134e16 add information collection for safari bots (flutter/engine#20123) * ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (flutter#19270)" (flutter/engine#20165) * 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161) * a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988) * 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101) * b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102) * 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104) * 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270) * d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105) * 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108) * 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109) * ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110) * f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067) * 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113) * 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114) * 49a40fa Enabled linting on engine.cc (flutter/engine#19981) * b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092) * 145ef60 Remove confusing logs (flutter/engine#20121) * 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126) * ec9e17c Roll zlib (flutter/engine#20119) * f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924) * 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968) * 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129) * 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133) * d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132) * 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125) * 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135) * 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136) * b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137) * adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138) * 941c442 Add ALERT SoundType enum value (flutter/engine#20139) * 19368ef Fix dartdocs of dart:ui (flutter/engine#20140) * 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141) * 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143) * 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146) * da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147) * 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148) * 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107) * 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105) * 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150) * 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152) * e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153) * f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127) * 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154) * 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155) * e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990) * f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158) * e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794) * c134e16 add information collection for safari bots (flutter/engine#20123) * ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (flutter#19270)" (flutter/engine#20165) * 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161) * a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988) * 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
add information(application location, application version, other safari related application) collection for safari bots.
This change won't break the build, since Safari tests only run system_profiler to collect information and exit by returning true.
relate issue: flutter/flutter#58012