-
Notifications
You must be signed in to change notification settings - Fork 6k
Use the GrDirectContext factories instead of deprecated GrContext ones #19962
Use the GrDirectContext factories instead of deprecated GrContext ones #19962
Conversation
f77d83a to
7443b60
Compare
61e43f6 to
65c67a6
Compare
|
The remaining failures seem like a tooling issue? @jason-simmons @gaaclarke thoughts on this? It's a big CL and I'm happy to talk more about the reason for it, but we'll have to do it eventually so we might as well rip the bandaid off. There's other API changes coming that are currently blocked by this (for instance, |
|
Hi Chinmay! It's been about 6 years, I think! |
|
Hey @Adlai-Holler , can you link to the documentation about the deprecation of GrContext in the description of the issue? As for the |
|
Thanks for the reply! I've added the NOLINT. Where should I file an issue? This repo doesn't seem to support them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! small world.
Thanks for the background. This should only affect Flutter once it starts building its own DDLs.
|
|
Issue filed at flutter/flutter#62222 Looks like we have only infra failures remaining on the CI. |
|
@Adlai-Holler I had those problems with CI yesterday. I haven't been able to verify if it is fixed now but rebasing your PR onto master should fix it. edit: Don't even worry about it. Once this gets through review we can rebase before we land. |
This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.
|
Rebased |
82806bf to
73d37d1
Compare
|
|
|
@gaaclarke @chinmaygarde Any chance we can get this in the bank today? |
|
The web stuff is unrelated and it seems to be referencing the framework which was broken at the time of the presubmit run. I am landing this now. |
More recontexting for SkImage. Chrome flag in CL 2323135. Flutter migration landed in flutter/engine#19962 Bug: skia:104662 Change-Id: Id725eb130310639457ba90f378ecdb334dd5f3cd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306182 Auto-Submit: Adlai Holler <[email protected]> Commit-Queue: Brian Salomon <[email protected]> Reviewed-by: Brian Salomon <[email protected]>
This is a followup to flutter#19962 to cover a few places where we were still using GrContext. No functional impact.
* Migrate a few last places to GrDirectContext This is a followup to #19962 to cover a few places where we were still using GrContext. No functional impact. * Formatting
This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.
Over time, GrContext will be replaced by:
SkCanvas->recordingContext,) we pretty much have the direct context handy at all times.Rough outline of what's going on is here. The key is SkDeferredDisplayLists – when dealing with them, which Flutter does not presently, the GrContext is actually incapable of talking to the GPU because it's not on the GPU's thread. Right now, the internal GrDDLContext you get just stubs off functionality that it can't perform, but this won't scale – we need to reveal this distinction to users so they can be clear about what's allowed and what's not.