-
Notifications
You must be signed in to change notification settings - Fork 6k
Show EGL configuration debugging when fail to create surface/context #19397
Show EGL configuration debugging when fail to create surface/context #19397
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite a bit of code that's largely tangential to the purpose of FlRenderer; could you move the printing code to a utility file?
It would also be good to get some unit testing for the printing utils, so that they are being exercised. Having had the experience of accidentally shipping a crasher in error logging code, I like to know that there's at least some sanity checking of rarely-run code in unit tests :)
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests!
Description
Show EGL configuration debugging when fail to create surface/context.
Related Issues
flutter/flutter#59960
Tests
No tests added.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.