-
Notifications
You must be signed in to change notification settings - Fork 6k
Move PersistentCache to flow/ #18968
Conversation
liyuqian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving PersistentCache into flow looks good as a follow-up step of #18938.
However, I'm a little concerned on the change of SetCacheVersion. It seems we didn't call SetCacheVersion anywhere in this PR, or set its default value. Does that mean we're just using an empty string as the version, so upgrading the engine version won't remove the old cache and create a new folder?
It's also unclear why we no longer want to set the engine version as the cache version, and instead let the embedder set it. The fxb/52961 seems to be only about build configs, and there's no mention of persistent cache versions.
e8391b4 to
567905b
Compare
567905b to
e229eb6
Compare
The latest PR sets the version properly from the Shell now. It was a WIP before.
It's not strictly necessary to have the embedder set the version, but I did that to preserve a good layering between shell/ and flow/ (shell depends on flow, not the other way around). This also allows the unittests to set their own version, and they are not tied to any hard-coded versioning logic like the Shell has. |
6b4c56c to
8def7a0
Compare
|
Needs minor cleanup and rebasing on #20422 |
ae11936 to
0ff3efe
Compare
PersistentCache no longer manages its version internally. It is the client's responsibility to inject a version directory at its discretion. shell/gpu/ no longer depends on shell/common after this, so there is no need to permute it for product / non-product configurations. BUG: fxb/52961
0ff3efe to
f1e07ee
Compare
PersistentCache no longer manages its version internally. It is the
client's responsibility to inject a version directory at its discretion.
shell/gpu/ no longer depends on shell/common after this, so there is no
need to permute it for product / non-product configurations.
BUG: fxb/52961