Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

robert-ancell
Copy link
Contributor

No description provided.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

Match the style used in the external plugins and more carefully vet the incoming
arguments.
@robert-ancell robert-ancell force-pushed the linux-shell-plugin-style branch from 25a3aac to c7d499e Compare June 8, 2020 23:06
@robert-ancell robert-ancell merged commit 320e805 into flutter:master Jun 8, 2020
@robert-ancell robert-ancell deleted the linux-shell-plugin-style branch June 8, 2020 23:36
cg021 pushed a commit to cg021/engine that referenced this pull request Jun 9, 2020
Match the style used in the external plugins and more carefully vet the incoming
arguments.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants