createOverlaySurface JNI

[cg021]

Description

Add JNI method createOverlaySurface for hybrid composition in the engine.

Related Issues

flutter/flutter#58288

Tests

I added the following tests:

createOverlaySurface__callsPlatformViewsController

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the contributor guide and followed the process outlined there for submitting PRs.
• I signed the CLA.
• I read and followed the C++, Objective-C, Java style guides for the engine.
• I read the tree hygiene wiki page, which explains my responsibilities.
• I updated/added relevant documentation.
• All existing and new tests are passing.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

• No, no existing tests failed, so this is not a breaking change.
• Yes, this is a breaking change. If not, delete the remainder of this section.
  • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
  • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
  • I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

[blasten]

why do we need these .gradle/** files? I think they can be reverted in case you didn't intend to commit them.

[cg021]

@blasten The format_and_dart_test failed and said that licenses_flutter needed that file added on line 14.

Collecting licenses for fuchsia
    Skipping this component - no change in signature
Collecting licenses for gpu
    Skipping this component - no change in signature
Collecting licenses for third_party
    Skipping this component - no change in signature
Collecting licenses for skia
    Skipping this component - no change in signature
============================= ERROR =============================
License script got different results than expected for out/license_script_output/licenses_flutter.
Please rerun the licenses script locally to verify that it is
correctly catching any new licenses for anything you may have
changed, and then update this file:
  flutter/sky/packages/sky_engine/LICENSE
For more information, see the script in:
  https://github.com/flutter/engine/tree/master/tools/licenses

[blasten]

surface needs the @NonNull annotation since it cannot be null.

[blasten]

Same comment about the annotation public FlutterOverlaySurface(long id, @NonNull Surface surface). id doesn't need one because it's a primitive type.

[blasten]

This class needs the @Keep annotation. This is because the C++ code will do lookup by method/class name. As a result, these names cannot change, but tools like Proguard or R8 make classes and methods names shorter to reduce code size.

[blasten]

There's now a centralized interface called PlatformViewAndroidJNI. For example, it has the FlutterViewDisplayOverlaySurface you added:

engine/shell/platform/android/jni/platform_view_android_jni.h

Lines 128 to 132 in e5845af

	virtual void FlutterViewDisplayOverlaySurface(int surface_id,
	int x,
	int y,
	int width,
	int height) = 0;

You would need to fix the conflicts and move the jni function to this interface.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[cg021]

Moved to #19040