This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Live region announcements for iOS #18798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Mac Host Engine is a flake - retrying at https://ci.chromium.org/p/flutter/builders/try/Mac%20Host%20Engine/6285 |
Member
|
LGTM |
goderbauer
approved these changes
Jun 3, 2020
lib/ui/semantics.dart
Outdated
| /// if the user does not have focus of the widget. | ||
| /// An example of a live region is a [SnackBar] widget. On Android and iOS, | ||
| /// live region causes a polite announcement to be generated automatically, | ||
| /// even if the user does not have focus of the widget. This announcement may |
Member
There was a problem hiding this comment.
nit: can we say: "even if the widget does not have accessibility focus" - I think that's slightly clearer.
dnfield
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
This was referenced Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2020
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements live region announcements for iOS.
If iOS 11 or greater is available, use a queued announcement. Otherwise, use a regular announcement.
This patch also drops the
FrequentlyUpdatestrait, which seems like it was just added as a misunderstanding at some point - that trait makes the screen reader less likely to read the change on a frequently changing value, and is recommended for things like timers./cc @vick08 @j-sid @cookiecrook @caseyburkhardt who provided feedback on the issue.
Related Issues
fixes flutter/flutter#45968 (there is no framework side to this component).
Tests
I added the following tests:
Tests for the new method on SemanticsObject that determines whether an announcement should be issued for live regions.
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.