This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Remove connection close on blur for desktop browsers #18743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2020 23:01
…s blurred (upon clicking another element on the page) on a desktop browser. keep the current behaviour for mobile browsers
mdebbar
reviewed
Jun 2, 2020
Comment on lines
623
to
631
| _subscriptions.add(domElement.onBlur.listen((_) { | ||
| if (domRenderer.windowHasFocus) { | ||
| // Focus is still on the body. Continue with blur. | ||
| owner.sendTextConnectionClosedToFrameworkIfAny(); | ||
| } else { | ||
| // Refocus. | ||
| domElement.focus(); | ||
| } | ||
| })); |
Contributor
There was a problem hiding this comment.
As discussed in chat, we need to refocus on blur in order for the keyboard to continue to work.
Contributor
Author
There was a problem hiding this comment.
done. thanks for catching this!
…firefox in the automated test. manually checks working
Contributor
Author
|
Linux Fuchsia bot has ended with infra error, the status is not synced back to github. |
Contributor
Author
|
Also Mac Engine Drone, Mac Android Debug Engine also failed with infra failures. Results are not updated to github. All these three tests are not related to current changes path. Current change only effects Flutter Web Engine. Merging the PR. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
This was referenced Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
This was referenced Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2020
stevenmetzger
added a commit
to stevenmetzger/engine
that referenced
this pull request
Nov 14, 2020
* Previously, Flutter for Web behaved like a web page. If user clicked on an area other than the input field itself, the input field was blurred, thus the connection is closed. This behavior was changed for Desktop Browsers. flutter#18743 Now only, pressing enter or tab changes the focus of the input fields. This created a regression for applications that relied on the old behavior flutter/flutter#64245 * This change adds a flag which will provides a workaround to the regression allowing developers to optionally force the connection to close on blur, as suggested in the comments flutter/flutter#64245 (comment)
10 tasks
|
coming here from flutter/flutter#55449 and wondering what the current approach would be to resolving the issue on mobile browsers. The example mentioned in the issue doesn't seem to work for me on a desktop browser as well, does this happen for other people too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close the text editing connection when an input text element is blurred (upon clicking another element on the page) on a desktop browser. Keep the current behavior for mobile browsers.
This change is requested on many issues:
flutter/flutter#49785
flutter/flutter#55042
flutter/flutter#55449
The features which expect the following behavior will be negatively effected:
(1) User enters text to a TextFormField-A
(2) User clicks on another item Element-B (or jumps to next field using tab)
(3) The onFieldSubmitted on TextFormField-A will trigger, since the editing of the field is finished.
The keyboard keys (Enter, Tab) will still trigger onFieldSubmitted.
Tested on: Chrome Desktop, Firefox, Safari Desktop.
Manually tested for a11y on Chrome Desktop.