Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

use a different flag to detect release branch for post submit tests #18655

Closed
wants to merge 1 commit into from
Closed

use a different flag to detect release branch for post submit tests #18655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tools/clone_flutter.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,18 @@ fi
# Go to the engine git repo to get the date of the latest commit.
cd $ENGINE_PATH/src/flutter

# Special handling of release branches.
# Special handling of release branches. We would like to run the tests against
# the release branch of flutter.
#
# On presubmit, we can get the branch name from the `CIRRUS_BASE_BRANCH` flag.
# During the commit tests the base branch value is empty, instead
# `CIRRUS_BRANCH` has the correct branch name.
ENGINE_BRANCH_NAME=$CIRRUS_BASE_BRANCH
Copy link
Contributor

@tvolkert tvolkert May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$CIRRUS_BASE_BRANCH should be surrounded with quotes here too

if [[ -z $CIRRUS_BASE_BRANCH ]]
Copy link
Contributor

@tvolkert tvolkert May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to surround $CIRRUS_BASE_BRANCH with quotes

then
Copy link
Contributor

@tvolkert tvolkert May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: typically then goes on the same line as the if in bash

echo "Running post commit tests use CIRRUS_BRANCH instead."
ENGINE_BRANCH_NAME=$CIRRUS_BRANCH
Copy link
Contributor

@tvolkert tvolkert May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surround with quotes

fi
versionregex="^v[[:digit:]]+\."
releasecandidateregex="^flutter-[[:digit:]]+\.[[:digit:]]+-candidate\.[[:digit:]]+$"
ON_RELEASE_BRANCH=false
Expand Down