This repository was archived by the owner on Feb 25, 2025. It is now read-only.
null-annotate SemanticsUpdateBuilder.updateNode #18552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looks like there's at least one legitimate failure in the presubmit. Will take a look and update the patch. |
The underlying _updateNode call requires that all parameters be set non-null. There's a single call site in the framework in lib/src/semantics/semantics.dart in SemanticsNode.updateWith(). At that call site, all parameters are either asserted non-null in the constructor of SemanticsData or defaulted to null, with the sole exception of textDirection. The ergonomics of this method are currently pretty ugly and we should consider migrating most of the defaulting and assertions that we apply at the call site up to the definition in dart:ui. That work is filed as flutter/flutter#57720.
yjbanov
approved these changes
May 26, 2020
Contributor
|
The Mac iOS Engine failure does not seem related. Merging, but will keep an eye on it, and revert if it causes trouble. |
Contributor
Since the same failure is happening consistently on the tree now, start with this PR, it seems likely that it was related, and did cause trouble. Reverting. |
stuartmorgan-g
pushed a commit
that referenced
this pull request
Jun 3, 2020
This reverts commit cc08940.
stuartmorgan-g
added a commit
that referenced
this pull request
Jun 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
This was referenced Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying _updateNode call requires that all parameters be set
non-null. There's a single call site in the framework in
lib/src/semantics/semantics.dart in SemanticsNode.updateWith(). At that
call site, all parameters are either asserted non-null in the
constructor of SemanticsData or defaulted to null, with the sole
exception of textDirection.
The ergonomics of this method are currently pretty ugly and we should
consider migrating most of the defaulting and assertions that we apply
at the call site up to the definition in dart:ui. That work is filed as
flutter/flutter#57720.