Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-enable Fuchsia tests #18342

Merged
merged 1 commit into from
May 13, 2020
Merged

Re-enable Fuchsia tests #18342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 43 additions & 38 deletions testing/fuchsia/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,11 @@

set -Ee

test_timeout_seconds=300

echo "These tests have been temporarily disabled."
echo "See: https://github.com/flutter/flutter/issues/57061"
exit 0
# This is longer than the test timeout as dumping the
# logs can sometimes take longer.
ssh_timeout_seconds=360
Copy link
Contributor

@godofredoc godofredoc May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like in some cases the timeouts are happening after 2 mins. That may be a default timeout inside fuchsia_ctl we may need to take a look.

Copy link
Contributor

@godofredoc godofredoc May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you are already covering it with the logs collection timeout.

Copy link
Contributor Author

@iskakaushik iskakaushik May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On glancing at the Fuchsia CTL code, the timeout passed here as an arg should override any default timeouts set. I kicked off a couple of runs to make sure that this does fix the issue. I'll keep an eye out for any potential failures.


# The nodes are named blah-blah--four-word-fuchsia-id
device_name=${SWARMING_BOT_ID#*--}
Expand All @@ -40,6 +41,7 @@ reboot() {

./fuchsia_ctl -d $device_name ssh \
-c "log_listener --dump_logs yes" \
--timeout-seconds $ssh_timeout_seconds \
--identity-file $pkey

echo "$(date) START:REBOOT ------------------------------------------"
Expand Down Expand Up @@ -71,55 +73,58 @@ tar -xvzf $2 -C packages 1> /dev/null
echo "$(date) END:EXTRACT_PACKAGES -----------------------------------"


# TODO (kaushikiska): Re-enable these tests.
# see: https://github.com/flutter/flutter/issues/57061
# TODO(gw280): Enable tests using JIT runner

# echo "$(date) START:flutter_runner_tests ----------------------------"
# ./fuchsia_ctl -d $device_name test \
# -f flutter_aot_runner-0.far \
# -f flutter_runner_tests-0.far \
# -t flutter_runner_tests \
# --identity-file $pkey \
# --timeout-seconds 300 \
# --packages-directory packages

# ./fuchsia_ctl -d $device_name test \
# -f flutter_aot_runner-0.far \
# -f flutter_runner_scenic_tests-0.far \
# -t flutter_runner_scenic_tests \
# --identity-file $pkey \
# --timeout-seconds 300 \
# --packages-directory packages
echo "$(date) START:flutter_runner_tests ----------------------------"
./fuchsia_ctl -d $device_name test \
-f flutter_aot_runner-0.far \
-f flutter_runner_tests-0.far \
-t flutter_runner_tests \
--identity-file $pkey \
--timeout-seconds $test_timeout_seconds \
--packages-directory packages

./fuchsia_ctl -d $device_name test \
-f flutter_aot_runner-0.far \
-f flutter_runner_scenic_tests-0.far \
-t flutter_runner_scenic_tests \
--identity-file $pkey \
--timeout-seconds $test_timeout_seconds \
--packages-directory packages

# TODO(https://github.com/flutter/flutter/issues/50032) Enable after the
# Fuchsia message loop migration is complete.
# echo "$(date) START:fml_tests ---------------------------------------"
# ./fuchsia_ctl -d $device_name test \
# -f fml_tests-0.far \
# -t fml_tests \
# -a "--gtest_filter=-MessageLoop*:Message*:FileTest*" \
# --identity-file $pkey \
# --timeout-seconds 300 \
# --packages-directory packages
echo "$(date) START:fml_tests ---------------------------------------"
./fuchsia_ctl -d $device_name test \
-f fml_tests-0.far \
-t fml_tests \
-a "--gtest_filter=-MessageLoop*:Message*:FileTest*" \
--identity-file $pkey \
--timeout-seconds $test_timeout_seconds \
--packages-directory packages


# echo "$(date) START:flow_tests --------------------------------------"
# ./fuchsia_ctl -d $device_name test \
# -f flow_tests-0.far \
# -t flow_tests \
# --identity-file $pkey \
# --timeout-seconds 300 \
# --packages-directory packages
echo "$(date) START:flow_tests --------------------------------------"
./fuchsia_ctl -d $device_name test \
-f flow_tests-0.far \
-t flow_tests \
--identity-file $pkey \
--timeout-seconds $test_timeout_seconds \
--packages-directory packages


# TODO(kaushikiska): Runtime and shell tests are failing with
# async_dispatcher failures. Re-enable them once this gets fixed.

# echo "$(date) START:runtime_tests -----------------------------------"
# ./fuchsia_ctl -d $device_name test \
# -f runtime_tests-0.far \
# -t runtime_tests \
# --identity-file $pkey \
# --timeout-seconds 300 \
# --timeout-seconds $test_timeout_seconds \
# --packages-directory packages


# TODO(https://github.com/flutter/flutter/issues/53399): Re-enable
# OnServiceProtocolGetSkSLsWorks and CanLoadSkSLsFromAsset once they pass on
# Fuchsia.
Expand All @@ -129,5 +134,5 @@ echo "$(date) END:EXTRACT_PACKAGES -----------------------------------"
# -t shell_tests \
# -a "--gtest_filter=-ShellTest.CacheSkSLWorks:ShellTest.SetResourceCacheSize*:ShellTest.OnServiceProtocolGetSkSLsWorks:ShellTest.CanLoadSkSLsFromAsset" \
# --identity-file $pkey \
# --timeout-seconds 300 \
# --timeout-seconds $test_timeout_seconds \
# --packages-directory packages