Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented May 12, 2020

Builds on #18220 and #18313

@robert-ancell robert-ancell marked this pull request as draft May 12, 2020 21:47
@auto-assign auto-assign bot requested a review from chinmaygarde May 12, 2020 21:48
@robert-ancell
Copy link
Contributor Author

This will fix flutter/flutter#54853 and flutter/flutter#30662.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick skim, my initial feedback (other than we should share a slightly refactored text input model if possible, per Discord discussion, since I would rather we not maintain N implementations of the same embedding-side model indefinitely) is to wonder why things like editing state callback handlers are in FlView. I think the text input "plugin" (poorly named, as it's not an actual plugin) structure that's used on most of the other embeddings (at least iOS, macOS, Windows, and GLFW) is a good separation of concerns. FlView is the kind of thing that can become increasingly large over time if we're not careful.

@robert-ancell robert-ancell changed the title Add FlTextInputChannel Add FlTextInputPlugin May 20, 2020
@robert-ancell robert-ancell marked this pull request as ready for review May 20, 2020 04:17
@auto-assign auto-assign bot requested a review from jason-simmons May 20, 2020 04:18
@robert-ancell robert-ancell force-pushed the linux-shell-fl-text-input-channel branch from 6c751e5 to 74ecb71 Compare May 21, 2020 00:30
@robert-ancell
Copy link
Contributor Author

robert-ancell commented May 21, 2020

Looks like I pushed this to the flutter/engine repo not robert-ancell/engine. I've been updating this in the wrong branch. I've pushed all my changes now and this should be ready for review.

@robert-ancell robert-ancell force-pushed the linux-shell-fl-text-input-channel branch 2 times, most recently from a49ecc2 to 10119bc Compare May 21, 2020 04:09
@robert-ancell robert-ancell force-pushed the linux-shell-fl-text-input-channel branch 2 times, most recently from ce78670 to c40a19b Compare May 27, 2020 05:02
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor changes.

@robert-ancell robert-ancell force-pushed the linux-shell-fl-text-input-channel branch from c40a19b to b0cf343 Compare May 27, 2020 23:14
@robert-ancell robert-ancell merged commit 2bd95d9 into master May 28, 2020
@robert-ancell robert-ancell deleted the linux-shell-fl-text-input-channel branch May 28, 2020 01:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants