Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

System mouse cursor: macOS #18131

Merged
merged 18 commits into from
May 20, 2020
Merged

System mouse cursor: macOS #18131

merged 18 commits into from
May 20, 2020

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented May 4, 2020 •
edited
Loading

Description

This PR adds system mouse cursor to the macOS engine.

This PR adds only a limited pool of system cursors. More will be added when the system is set up.

Related Issues

@auto-assign auto-assign bot requested a review from liyuqian May 4, 2020 22:10
stuartmorgan-g
stuartmorgan-g suggested changes May 7, 2020
View reviewed changes
shell/platform/darwin/macos/framework/Source/FlutterViewController.mm Outdated
FlutterDartProject* _project;

// The plugin used to handle mouse cursor. This is not an FlutterPlugin, so must be owned
// separately.
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the other comment I don't think this is true, in which case you wouldn't need an ivar for it.

stuartmorgan-g
stuartmorgan-g suggested changes May 11, 2020
View reviewed changes
@dkwingsmt dkwingsmt requested a review from stuartmorgan-g May 19, 2020 20:49
stuartmorgan-g
stuartmorgan-g approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment nits!

@stuartmorgan-g stuartmorgan-g mentioned this pull request May 20, 2020
Closed
@dkwingsmt dkwingsmt merged commit 69d0a8e into flutter:master May 20, 2020
@dkwingsmt dkwingsmt deleted the system-mouse-cursor-macos branch May 20, 2020 23:27
@gspencergoog gspencergoog mentioned this pull request May 20, 2020
Open
17 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
e5ac7dd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
f0ad689
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
884d84b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
2e6bafc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
4274c1d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
ca781c8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
9e07388
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
6e643c7
wandyers pushed a commit to wandyers/engine that referenced this pull request May 23, 2020
@dkwingsmt @wandyers
System mouse cursor: macOS (flutter#18131)
2bebc80 
* Untested macOS impl

* Workable mac

* Modernize

* Simplify

* Address comments

* Refactor with FlutterPlugin

* Cached dict

* Update per comments

* format

* Remove device arg

* Format

* Update license

* Update licences

* Doc update
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
13c26fd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
a5e537f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
4f34ca8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
20882b2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
69d0a8e System mouse cursor: macOS (flutter/engine#18131)
c6794a9
liyuqian added a commit to liyuqian/flutter that referenced this pull request May 26, 2020
@liyuqian
Roll Engine from 9ce1e5c to 1a83498 (69 revisions)
0516672 
Roll Engine from 9ce1e5c to 1a83498 (69 revisions)

flutter/engine@9ce1e5c...1a83498

2020-05-26 [email protected] Revert "Update CanvasKit to 0.15.0 (flutter#18570)" (flutter/engine#18600)
2020-05-26 [email protected] Roll Fuchsia Mac SDK from TSEOq... to hr-HZ... (flutter/engine#18594)
2020-05-26 [email protected] Roll Dart SDK from 65113fd73dec to 9e3b0289197d (2 revisions) (flutter/engine#18593)
2020-05-26 [email protected] Roll Skia from b6d158aaf3dd to e4b4ca1050b9 (1 revision) (flutter/engine#18592)
2020-05-26 [email protected] Roll Fuchsia Linux SDK from DzG49... to pLp67... (flutter/engine#18591)
2020-05-24 [email protected] Roll Fuchsia Mac SDK from Oz016... to TSEOq... (flutter/engine#18590)
2020-05-23 [email protected] Roll Skia from afd8a6c6ae87 to b6d158aaf3dd (3 revisions) (flutter/engine#18588)
2020-05-22 [email protected] Roll Fuchsia Mac SDK from 99Z4_... to Oz016... (flutter/engine#18582)
2020-05-22 [email protected] Roll Skia from ec31488ace66 to afd8a6c6ae87 (1 revision) (flutter/engine#18581)
2020-05-22 [email protected] Roll Fuchsia Linux SDK from Kvwlr... to DzG49... (flutter/engine#18580)
2020-05-22 [email protected] Roll Skia from 80abb89c3632 to ec31488ace66 (1 revision) (flutter/engine#18579)
2020-05-22 [email protected] Roll Skia from da90c3765908 to 80abb89c3632 (4 revisions) (flutter/engine#18577)
2020-05-22 [email protected] Roll Fuchsia Mac SDK from _zNmv... to 99Z4_... (flutter/engine#18576)
2020-05-22 [email protected] Roll Skia from 317dce5c81c0 to da90c3765908 (1 revision) (flutter/engine#18575)
2020-05-22 [email protected] Roll Dart SDK from 4ee57c08e0a6 to 65113fd73dec (3 revisions) (flutter/engine#18574)
2020-05-22 [email protected] Roll Skia from 67e21a19259b to 317dce5c81c0 (3 revisions) (flutter/engine#18573)
2020-05-22 [email protected] Update CanvasKit to 0.15.0 (flutter/engine#18570)
2020-05-21 [email protected] Roll Skia from 3d52abc84667 to 67e21a19259b (1 revision) (flutter/engine#18568)
2020-05-21 [email protected] Roll Dart SDK from 396b5fb7a97d to 4ee57c08e0a6 (6 revisions) (flutter/engine#18567)
2020-05-21 [email protected] Add fl_value_to_string (flutter/engine#18540)
2020-05-21 [email protected] Roll Skia from 1e63279156d6 to 3d52abc84667 (5 revisions) (flutter/engine#18566)
2020-05-21 [email protected] null-annotate semantics.dart (flutter/engine#18553)
2020-05-21 [email protected] Roll Fuchsia Linux SDK from ciqRH... to Kvwlr... (flutter/engine#18565)
2020-05-21 [email protected] Roll Skia from b37105ea6cca to 1e63279156d6 (9 revisions) (flutter/engine#18564)
2020-05-21 [email protected] Implement WriteAtomically using write/fsync on all platforms, and enable (flutter/engine#18320)
2020-05-21 [email protected] Roll Dart SDK from ecce58c1e354 to 396b5fb7a97d (2 revisions) (flutter/engine#18560)
2020-05-21 [email protected] Roll Fuchsia Mac SDK from RNByJ... to _zNmv... (flutter/engine#18558)
2020-05-21 [email protected] [profiling] Memory Profiling support for iOS (flutter/engine#18516)
2020-05-21 [email protected] Roll Skia from 22636205ce92 to b37105ea6cca (2 revisions) (flutter/engine#18557)
2020-05-21 [email protected] Roll Dart SDK from d551980ac9fc to ecce58c1e354 (2 revisions) (flutter/engine#18556)
2020-05-21 [email protected] Roll Dart SDK from bf7e9d13d730 to d551980ac9fc (6 revisions) (flutter/engine#18551)
2020-05-21 [email protected] Roll Skia from 4c0578632217 to 22636205ce92 (4 revisions) (flutter/engine#18550)
2020-05-21 [email protected] Roll Fuchsia Linux SDK from ThMeW... to ciqRH... (flutter/engine#18549)
2020-05-21 [email protected] Roll Skia from 67ff541ac116 to 4c0578632217 (1 revision) (flutter/engine#18547)
2020-05-21 [email protected] Let run_tests.py just stream output (flutter/engine#18534)
2020-05-21 [email protected] Add FlKeyEventPlugin (flutter/engine#18313)
2020-05-21 [email protected] Add tests for StandardMethodCodec (flutter/engine#18521)
2020-05-21 [email protected] Roll Skia from f83baf230c69 to 67ff541ac116 (1 revision) (flutter/engine#18545)
2020-05-21 [email protected] Roll Fuchsia Mac SDK from 3o9aQ... to RNByJ... (flutter/engine#18543)
2020-05-21 [email protected] fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492)
2020-05-21 [email protected] Roll Skia from d2dc8ddcdf5e to f83baf230c69 (2 revisions) (flutter/engine#18539)
2020-05-21 [email protected] Roll Dart SDK from 7aa8656d1dd8 to bf7e9d13d730 (21 revisions) (flutter/engine#18538)
2020-05-21 [email protected] Add FlMethodChannel, FlMethodCodec, FlStandardMethodCodec and FlJsonMethodCodec (flutter/engine#18220)
2020-05-20 [email protected] [web] Fix arc rendering when it starts a new sub path. (flutter/engine#18535)
2020-05-20 [email protected] Send platformResolvedLocale from iOS embedder (flutter/engine#18519)
2020-05-20 [email protected] System mouse cursor: macOS (flutter/engine#18131)
...
@liyuqian liyuqian mentioned this pull request May 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@liyuqian liyuqian Awaiting requested review from liyuqian

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkwingsmt @stuartmorgan-g @googlebot