This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Add support for ColorFilter on images #18111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
May 4, 2020
| ui.Image image, ui.Offset p, SurfacePaintData paint) { | ||
| final HtmlImage htmlImage = image; | ||
| final html.Element imgElement = htmlImage.cloneImageElement(); | ||
| final ui.BlendMode blendMode = paint.blendMode; |
Contributor
There was a problem hiding this comment.
nit: this line should move down, closer to the location where it's used
| } | ||
| } | ||
|
|
||
| const String _flutterLogoBase64 = |
Contributor
There was a problem hiding this comment.
Let's document (or put in the variable name) the size of the test image.
| (swapLayers | ||
| ? '<feBlend in="SourceGraphic" in2="flood" mode="$feBlend"/>' | ||
| : '<feBlend in="flood" in2="SourceGraphic" mode="$feBlend"/>') + | ||
| '</filter></svg>'; |
Contributor
There was a problem hiding this comment.
These SVG snippets contain a lot of static content that need to be parsed from HTML. Wouldn't using the SVG API be more efficient?
Contributor
Author
There was a problem hiding this comment.
Didn't want to pull in svg library, not as big as dart:html but not small.
Contributor
There was a problem hiding this comment.
Something tells me we already have it all included :)
It's OK. We can profile it later and see what the size/speed trade-off is like.
Co-authored-by: Harry Terkelsen <[email protected]>
Contributor
Author
|
Mac Web Engine passed at https://ci.chromium.org/p/flutter/builders/try/Mac%20Web%20Engine/3029 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 6, 2020
GaryQian
pushed a commit
to flutter/flutter
that referenced
this pull request
May 6, 2020
* c2c6ad9 Roll src/third_party/skia 41e377d1baf0..3d311a983bf0 (9 commits) (flutter/engine#18150) * a0983d3 [web] Add support for ColorFilter on images (flutter/engine#18111) * 905836d [web] Upgrade the test package to remove the dependency on package_resolver (flutter/engine#18135) * 0645e93 Manually add dependency for shelf_proxy (flutter/engine#18151) * d104f87 Roll src/third_party/skia 3d311a983bf0..0cbd58766ace (2 commits) (flutter/engine#18152) * b1b1df0 Roll fuchsia/sdk/core/mac-amd64 from ERGnT... to c5NQZ... (flutter/engine#18155) * 8a8cd5d Roll src/third_party/dart 7bb38670d279..1ef444139c4c (22 commits) (flutter/engine#18161) * c1068de gpu_metal_surface `submitframe` return false when canvas is null (flutter/engine#18154) * cf13c7f [iOS platform view] fix active_composition_order_ never cleared (flutter/engine#18153) * 805a887 Add first Linux shell tests (flutter/engine#18159) * 80c090d Fix path bounds for multiple rects. Implement winding rules (flutter/engine#18165) * 15752ee Roll src/third_party/skia 0cbd58766ace..e1c0cb3de8ab (8 commits) (flutter/engine#18167) * c1bd64a Roll src/third_party/skia e1c0cb3de8ab..1e8fb04b29b9 (3 commits) (flutter/engine#18168) * 6a379cc Roll fuchsia/sdk/core/linux-amd64 from gnNdl... to RpHTv... (flutter/engine#18171) * 961fa14 Roll src/third_party/dart 1ef444139c4c..8c8249fa0123 (11 commits) (flutter/engine#18172) * 337ec63 Roll src/third_party/skia 1e8fb04b29b9..c5727d8e34d2 (1 commits) (flutter/engine#18173) * bc30355 Roll src/third_party/skia c5727d8e34d2..999257d870d7 (5 commits) (flutter/engine#18174) * c3cd83b Roll fuchsia/sdk/core/mac-amd64 from c5NQZ... to jMJqf... (flutter/engine#18175) * Updated bin/internal/fuchsia-linux.version * Updated bin/internal/fuchsia-mac.version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: flutter/flutter#56071 , flutter/flutter#50897
Verified by comparing native vs web. Golden tests results: flutter/goldens#92