Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@nturgut
Copy link
Contributor

@nturgut nturgut commented Apr 28, 2020

print the git branch output

found result: BRANCH='* (no branch)'. Therefore using the clone_flutter.sh we are not able to get the engine branch.

Solution: $CIRRUS_BASE_BRANCH can be used for branch name: https://cirrus-ci.com/task/6753845336342528?command=fetch_framework#L5

Successful run: https://cirrus-ci.com/task/6347234272870400

Fixes flutter/flutter#55884

@nturgut nturgut added the Work in progress (WIP) Not ready (yet) for review! label Apr 28, 2020
@auto-assign auto-assign bot requested a review from iskakaushik April 28, 2020 01:39
@nturgut nturgut removed the request for review from iskakaushik April 28, 2020 01:53
@nturgut nturgut closed this Apr 28, 2020
@nturgut nturgut reopened this Apr 28, 2020
@nturgut
Copy link
Contributor Author

nturgut commented Apr 28, 2020

According to this doc:https://cirrus-ci.org/guide/writing-tasks/ $CIRRUS_BRANCH or $CIRRUS_BASE_BRANCH should give us the branch name. I'll also try these.

@nturgut nturgut requested a review from pcsosinski April 28, 2020 18:03
@nturgut nturgut removed the Work in progress (WIP) Not ready (yet) for review! label Apr 28, 2020
@nturgut
Copy link
Contributor Author

nturgut commented Apr 28, 2020

Send out PR #18014 for the master branch.

@nturgut nturgut closed this Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants