This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Replace RasterCache::Get with RasterCache:Draw #17791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
reviewed
Apr 17, 2020
flar
reviewed
Apr 17, 2020
flar
suggested changes
Apr 17, 2020
flar
suggested changes
Apr 17, 2020
flar
reviewed
Apr 20, 2020
liyuqian
force-pushed
the
raster_cache_matrix
branch
from
5981e25 to
e25f277
Compare
Contributor
|
The most recent commit had the description that it was tightening the assert when, in fact, it was loosening it. Also, why was that change made? |
This avoids the possible matrix mismatch between RasterCache::Get and RasterCacheResult::draw. See flutter#17790 for an example that tries to fix an earlier mismatch.
This reverts commit b428ca1. The rare floating point error may cause the 1-off difference. Although in most cases, they should exactly match.
liyuqian
force-pushed
the
raster_cache_matrix
branch
from
3742eba to
5cf9804
Compare
Contributor
Author
|
@flar : do you mean the Revert "Tighten the assert" commit? The reason of that revert is in the commit description:
|
Contributor
|
Still LGTM... |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 24, 2020
liyuqian
added a commit
that referenced
this pull request
May 1, 2020
This reverts commit b5aedb3 and relands #17712. Fixes flutter/flutter#53288 and flutter/flutter#41654. Together with #17791, this reland addresses some of Jim's concerns in the original PR #17712. The major part of this PR is still the same as the original PR, and the performance / golden image impacts should be the same.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the possible matrix mismatch between RasterCache::Get and
RasterCacheResult::draw. See
#17790 for an example that tries
to fix an earlier mismatch.