This repository was archived by the owner on Feb 25, 2025. It is now read-only.
PlatformResolvedLocale localization message channel #17755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
changed the title
lib/ui/window.dart
Outdated
| /// The locale that the platform's native locale resolution system resolves to. | ||
| /// | ||
| /// This value may differ between platforms and is meant to allow flutter locale | ||
| /// resoltion algorithms to into resolving consistently with other apps on the |
There was a problem hiding this comment.
typo: "resolution"
also "to into resolving" doesn't sound right
lib/ui/window.dart
Outdated
|
|
||
| /// The locale that the platform's native locale resolution system resolves to. | ||
| /// | ||
| /// This value may differ between platforms and is meant to allow flutter locale |
GaryQian
added
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 22, 2020
swift-kim
added a commit
to swift-kim/engine
that referenced
this pull request
Jul 16, 2021
The code is dead because flutter#17755 has been reverted by flutter#19136 but flutter#18519 has not been properly reverted.
swift-kim
added a commit
to swift-kim/engine
that referenced
this pull request
Jul 16, 2021
The code is dead because flutter#17755 has been reverted by flutter#19136, although flutter#18519 has not been properly reverted.
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the core engine message system for passing PlatformResolvedLocale from embedders up to the dart isolate.
There is also a very simple android usage of the API that will just produce en_US. This value is currently discarded by the framework until the necessary changes are implemented there.
Part of a series of changes to address flutter/flutter#47087
doc: go/flutter-embedder-localization