This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Improve C++ plugin lifetime handling" #17570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relands flutter#17489 with a fix for the unit test flake.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 7, 2020
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 8, 2020
* fd10734 Fix flutter_windows_unittests runtime dependency (flutter/engine#17524) * 8f6590c Added "unrecognized-selector" errors to match g3 builds (flutter/engine#17566) * 5b4b1f3 Reland "Improve C++ plugin lifetime handling" (flutter/engine#17570) * Updated bin/internal/fuchsia-linux.version
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
Relands flutter#17489 with a fix for the unit test flake. The previous unit test relied on the new instance not being created at the same memory address, which isn't guaranteed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #17489 with a fix for the unit test flake.
The previous unit test relied on the new instance not being created at the same memory address, which isn't guaranteed.