This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[tools][fuchsia] Reland "Do not tar debug symbol CIPD uploads" #17506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuchsia is the main consumer of these CIPD packages and - to simplify its infrastructure - it is migrating its SDK partners over to producing a CIPD package containing a flat .build-id directory. This change also updates the CIPD package so that the .build-id directory is placed at the root. Bug: fxbug.dev/41443
Contributor
Author
|
@iskakaushik has full context on this change. |
Member
|
This is causing LUCI errors on this build. |
iskakaushik
added a commit
that referenced
this pull request
Apr 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2020
tvolkert
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 6, 2020
* 0945635 Roll src/third_party/skia cc8a76f3c763..04513752fd6e (22 commits) (flutter/engine#17529) * faf44fe Improve C++ plugin lifetime handling (flutter/engine#17489) * 4b69cf2 [tools][fuchsia] Do not tar debug symbol CIPD uploads (flutter/engine#17506) * 19a7fbf Fixed nullability in plugin header and overridden type mismatch error. (flutter/engine#17532) * ab434c5 Revert "[tools][fuchsia] Do not tar debug symbol CIPD uploads (#17506)" (flutter/engine#17537)
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
Fuchsia is the main consumer of these CIPD packages and - to simplify its infrastructure - it is migrating its SDK partners over to producing a CIPD package containing a flat .build-id directory. This change also updates the CIPD package so that the .build-id directory is placed at the root. Bug: fxbug.dev/41443
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…r#17506)" (flutter#17537) This reverts commit 4b69cf2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia is the main consumer of these CIPD packages and - to simplify
its infrastructure - it is migrating its SDK partners over to producing
a CIPD package containing a flat .build-id directory.
This change also updates the CIPD package so that the .build-id
directory is placed at the root.
Bug: fxbug.dev/41443