This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove unused or unnecessary compiler specific marcos in FML. #17101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
added
the
waiting for tree to go green
jason-simmons
approved these changes
Mar 11, 2020
Macros to control inlining are not used and we explicitly recommending against playing with compiler inlining. The macros for alignment became part of the standard in C++11 and we already use the standard variants over these macros (see `PointerData`). The formatters are unused as well and we use the stream based variants for formatting.
chinmaygarde
force-pushed
the
modernize_align
branch
from
5358852 to
ab0d152
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros to control inlining are not used and we explicitly recommending against
playing with compiler inlining. The macros for alignment became part of the
standard in C++11 and we already use the standard variants over these macros
(see
PointerData). The formatters are unused as well and we use the streambased variants for formatting.