Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove the unused method on iOS surface to make the resource context current. #17084

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Remove the unused method on iOS surface to make the resource context current. #17084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions shell/platform/darwin/ios/ios_surface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ class IOSSurface : public ExternalViewEmbedder {

ExternalViewEmbedder* GetExternalViewEmbedderIfEnabled();

bool ResourceContextMakeCurrent();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The implementation has now drifted a bit from the Android side. I don't think that's necessarily a problem, but it does make things a bit harder to understand on both sides. Not sure if it's worth refactoring Android the way iOS was refactored.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. It may be worth having an embedder support library for this.


virtual bool IsValid() const = 0;

virtual void UpdateStorageSizeIfNecessary() = 0;
Expand Down
4 changes: 0 additions & 4 deletions shell/platform/darwin/ios/ios_surface.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,6 @@ bool IsIosEmbeddedViewsPreviewEnabled() {

IOSSurface::~IOSSurface() = default;

bool IOSSurface::ResourceContextMakeCurrent() {
return GetContext()->ResourceMakeCurrent();
}

std::shared_ptr<IOSContext> IOSSurface::GetContext() const {
return ios_context_;
}
Expand Down