Add build_and_test_linux_release presubmit test #17073
Conversation
|
@chinmaygarde : the new code still fails. I wonder if |
|
@chinmaygarde , I've found the issue: there's also a whitelist unit test. Although the failure is about the blacklisted flags, it now comes from the whitelist unit test instead of the blacklist unit test. Fixing whitelist unit test seems to have fixed the issue. |
| RunEngineBenchmarks(build_dir, engine_filter) | ||
|
|
||
| if 'engine' in types or 'font-subset' in types: | ||
| if ('engine' in types or 'font-subset' in types) and args.variant != 'host_release': |
There was a problem hiding this comment.
@dnfield : the font-subset doesn't seem to be available in release mode. I also wonder if it's available in the profile mode. Is it debug mode only?
There was a problem hiding this comment.
I think only the debug mode asset is built - it should be possible to build the release mode, but not important to test it in release mode.
liyuqian
force-pushed
the
release_test
branch
2 times, most recently
from
d874224 to
6377cb0
Compare
Also enable shell_benchmarks in postsubmit release benchmarks.
That's the intended behavior according to Ben.
Chinmay said terminate on release is the intended behavior.
liyuqian
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
liyuqian
added
the
waiting for tree to go green
Also enable shell_benchmarks in postsubmit release benchmarks.