This repository was archived by the owner on Feb 25, 2025. It is now read-only.
URL-encode asset URLs so assets are properly loaded #16630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it might be some wonky logic in my web server implementation. Let me patch in your change locally so I can check |
|
Thanks for the fix on the tool side, Jonah. I added a comment so this should be ready to go now |
yjbanov
approved these changes
Feb 18, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2020
iskakaushik
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 20, 2020
* 48d64c1 update hash code logic on the web (flutter/engine#16624) * 110c1c9 Lift restriction that embedders may not trample the render thread OpenGL context in composition callbacks. (flutter/engine#16653) * ca6165f Roll src/third_party/skia c1bb9cba16be..7281a8623799 (9 commits) (flutter/engine#16665) * c264e1c Roll src/third_party/dart 999eeea5a3ff..3883c6070942 (5 commits) (flutter/engine#16666) * 1cd1304 Control test timeouts based on debugger status or command line flags. (flutter/engine#16375) * 9309ff5 Roll src/third_party/skia 7281a8623799..fe6fe6c5a8a8 (7 commits) (flutter/engine#16667) * d03582d URL-encode asset URLs so assets are properly loaded (flutter/engine#16630) * 40e3ab1 Roll fuchsia/sdk/core/mac-amd64 from 06MUz... to _jvYk... (flutter/engine#16668) * ef9e7b1 Revert "Lift restriction that embedders may not trample the render thread OpenGL context in composition callbacks. (#16653)" (flutter/engine#16674) * 16eeac5 Roll src/third_party/skia fe6fe6c5a8a8..799a23cf0602 (1 commits) (flutter/engine#16669) * c796205 Roll fuchsia/sdk/core/linux-amd64 from 2W9Xr... to VHyDa... (flutter/engine#16670) * 4f4a1d5 Roll src/third_party/dart 3883c6070942..c11c0ae3fdca (9 commits) (flutter/engine#16673) * 80f73ee Roll src/third_party/skia 799a23cf0602..d0d033a12556 (3 commits) (flutter/engine#16675) * 151688c Roll src/third_party/skia d0d033a12556..a037445e07a7 (4 commits) (flutter/engine#16676) * 8e82311 Roll src/third_party/skia a037445e07a7..c5ff41f2976e (1 commits) (flutter/engine#16677) * 84dc383 Roll src/third_party/dart c11c0ae3fdca..707ecda05e14 (1 commits) (flutter/engine#16678)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
* URL-encode asset URLs so assets are properly loaded * Add comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#50333
What works with this fix:
flutter run -d web-server --profileflutter run -d web-server --releaseflutter build webWhat breaks with this fix:
flutter run -d web-server@jonahwilliams Do you know what would cause DDC and dart2js modes to serve differently?