This repository was archived by the owner on Feb 25, 2025. It is now read-only.
improve surface state assert error messages #16595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
force-pushed
the
better-surface-state-info
branch
from
644d3db to
ff81113
Compare
mdebbar
approved these changes
Feb 13, 2020
| /// Verifies that the [surface] is in one of the valid states. | ||
| /// | ||
| /// This function should be used inside an assertion expression. | ||
| bool debugAssertSurfaceState(PersistedSurface surface, PersistedSurfaceState state1, [PersistedSurfaceState state2, PersistedSurfaceState state3]) { |
There was a problem hiding this comment.
I'm curious why you chose this signature vs passing an array of states.
There was a problem hiding this comment.
Which one is better
This?
assert(debugAssertSurfaceState(oldSurface, PersistedSurfaceState.active, PersistedSurfaceState.pendingUpdate));Or this?
assert(debugAssertSurfaceState(oldSurface, const <PersistedSurfaceState>[PersistedSurfaceState.active, PersistedSurfaceState.pendingUpdate]))There was a problem hiding this comment.
Ah right. Explicit types :(
| bool debugAssertSurfaceState(PersistedSurface surface, PersistedSurfaceState state1, [PersistedSurfaceState state2, PersistedSurfaceState state3]) { | ||
| final List<PersistedSurfaceState> validStates = [ state1, state2, state3 ]; | ||
|
|
||
| if (validStates.contains(surface.state)) { |
There was a problem hiding this comment.
Is surface.state nullable? If it's null, it could mistakenly pass this check.
There was a problem hiding this comment.
It is not nullable. We have an assert for that.
There was a problem hiding this comment.
I can't wait for Null Safety!
|
Build redness is Fuchsia infra flakiness |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2020
jason-simmons
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 18, 2020
* c0549fb Roll buildroot. (flutter/engine#16613) * 8b0b649 improve surface state assert error messages (flutter/engine#16595) * cd77e78 Fix drawRRect failure when shader is specified (flutter/engine#16601) * fe63094 [web] Handle alignment correctly in Paragraph.getPositionForOffset (flutter/engine#16569) * 65d1126 [web] Fixing launching Safari. This should solve the LUCI issue (flutter/engine#16590) * f88f7df [web] Unskip tests that are already passing in Safari (flutter/engine#16567) * 594f660 [shell tests] Integrate Vulkan with Shell Tests * 400ed7c Revert "[shell tests] Integrate Vulkan with Shell Tests" * 15e7f51 Implement Path extractPath, tangent APIs (flutter/engine#16599) * 4941ff7 Remove usage of Dart_AllocateWithNativeFields from tonic (flutter/engine#16588) * bb01cb7 Roll fuchsia/sdk/core/linux-amd64 from Bmq1m... to J-_s6... (flutter/engine#16592)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit 7016506.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.