Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

gaaclarke
Copy link
Member

Relevant issue: flutter/flutter#41679

@gaaclarke gaaclarke marked this pull request as ready for review January 30, 2020 23:53
@auto-assign auto-assign bot requested a review from iskakaushik January 30, 2020 23:53
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a headerdoc brief to the FlutterCoalescer that describes why this is necessary and when it will be used? It is not entirely obvious from the implementation.

@gaaclarke
Copy link
Member Author

Can you add a headerdoc brief to the FlutterCoalescer that describes why this is necessary and when it will be used? It is not entirely obvious from the implementation.

done

@gaaclarke gaaclarke merged commit 71de21c into flutter:master Jan 31, 2020
@gaaclarke
Copy link
Member Author

Submitting on red (it's a purple flake).

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 31, 2020
flutter/engine@804dca6...6b8c150

git log 804dca6..6b8c150 --first-parent --oneline
2020-01-31 [email protected] Use static constexpr for iphone_xs_times (flutter/engine#16264)
2020-01-31 [email protected] Started coalescing updates to viewport metrics after foregrounding the app. (flutter/engine#16270)
2020-01-31 [email protected] Remove superfluous INFO logs from //flutter/runtime. (flutter/engine#16280)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants