This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ensure we export the various dart snapshot symbols on Fuchsia #15953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gw280
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
This was referenced Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2020
flutter/engine@f10f03a...51a7964 git log f10f03a..51a7964 --first-parent --oneline 2020-01-24 [email protected] Roll src/third_party/dart bc9348829ef8..fc3af737c759 (2 commits) (flutter/engine#15965) 2020-01-24 [email protected] Roll fuchsia/sdk/core/linux-amd64 from Wc7e4... to 8Ns10... (flutter/engine#15964) 2020-01-24 [email protected] Roll src/third_party/skia a7e557f3e353..3ea4d5bb857d (4 commits) (flutter/engine#15963) 2020-01-24 [email protected] Roll src/third_party/dart c359b5943a52..bc9348829ef8 (1 commits) (flutter/engine#15962) 2020-01-24 [email protected] ensure we export the various dart snapshot symbols on Fuchsia (flutter/engine#15953) 2020-01-24 [email protected] Roll src/third_party/dart 3eaae5405d37..c359b5943a52 (13 commits) (flutter/engine#15959) 2020-01-24 [email protected] Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (flutter/engine#15118) 2020-01-24 [email protected] Re-arm timer as necessary in MessageLoopFuchsia 2020-01-24 [email protected] Roll src/third_party/skia c88a3bc3f561..a7e557f3e353 (6 commits) (flutter/engine#15957) 2020-01-24 [email protected] Roll fuchsia/sdk/core/mac-amd64 from LAOYs... to 6_pZp... (flutter/engine#15954) 2020-01-24 [email protected] Fixes FlutterCallbackInfomation leaks (flutter/engine#15089) 2020-01-24 [email protected] Fixes oc leaks in platform plugin (flutter/engine#15041) 2020-01-24 [email protected] Do not reset the child isolate preparer if the isolate group data already has one (flutter/engine#15952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…flutter#15953)" This reverts commit 51f5371.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building in JIT mode, we package the dart isolate/vm snapshots in the binary and export the symbols for lookup using
dlsym.We need to ensure these symbols are exported correctly on Fuchsia so that
shell_unittestscan initalise properly.