Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Throw an exception in Image.toByteData rather than hang forever. #15152

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Throw an exception in Image.toByteData rather than hang forever. #15152

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d51445
Throw an exception in `Image.toByteData` rather than hang forever.
harryterkelsen Jan 6, 2020
d62e382
Merge branch 'master' into image-tobytedata-throw
harryterkelsen Jan 6, 2020
0a863fb
Merge branch 'master' into image-tobytedata-throw
harryterkelsen Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/web_ui/lib/src/engine/html_image_codec.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ class HtmlImage implements ui.Image {
}
}

// TODO(het): Support this for asset images and images generated from
// `Picture`s.
/// Returns an error message on failure, null on success.
String _toByteData(int format, Callback<Uint8List> callback) => null;
String _toByteData(int format, Callback<Uint8List> callback) {
callback(null);
return 'Image.toByteData is not supported in Flutter for Web';
}
}