Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Force the a11y focused node for a screen change notification on iOS. #14513

Closed
wants to merge 2 commits into from
Closed

Force the a11y focused node for a screen change notification on iOS. #14513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d999bdd
Change the screen change notification on iOS to
darrenaustin Dec 14, 2019
187b575
Update to fix formatting
darrenaustin Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,20 +224,21 @@ - (BOOL)onCustomAccessibilityAction:(FlutterCustomAccessibilityAction*)action {
return YES;
}

- (NSString*)routeName {
// Returns the first non-null and non-empty semantic label of a child
// with an NamesRoute flag. Otherwise returns nil.
- (id)routeFocusObject {
// Returns the first SemanticObject in this branch that has
// the NamesRoute flag with a non-nil semantic label. Otherwise
// returns nil.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it guaranteed that a node with kNamesRoute is always focusable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so. In the isAccessibilityElement method on SemanticsObject it uses:

  return (([self node].flags & ~flutter::kScrollableSemanticsFlags) != 0 &&
          [self node].flags != static_cast<int32_t>(flutter::SemanticsFlags::kIsHidden)) ||
         ![self node].label.empty() || ![self node].value.empty() || ![self node].hint.empty() ||
         ([self node].actions & ~flutter::kScrollableSemanticsActions) != 0;

So any node with a label should be a11y focusable.

if ([self node].HasFlag(flutter::SemanticsFlags::kNamesRoute)) {
NSString* newName = [self accessibilityLabel];
if (newName != nil && [newName length] > 0) {
return newName;
NSString* label = [self accessibilityLabel];
if (label != nil && [label length] > 0) {
return self;
}
}
if ([self hasChildren]) {
for (SemanticsObject* child in self.children) {
NSString* newName = [child routeName];
if (newName != nil && [newName length] > 0) {
return newName;
SemanticsObject* labelObject = [child routeFocusObject];
if (labelObject != nil) {
return labelObject;
}
}
}
Expand Down Expand Up @@ -733,8 +734,8 @@ - (BOOL)accessibilityScroll:(UIAccessibilityScrollDirection)direction {

layoutChanged = layoutChanged || [doomed_uids count] > 0;
if (routeChanged) {
NSString* routeName = [lastAdded routeName];
UIAccessibilityPostNotification(UIAccessibilityScreenChangedNotification, routeName);
UIAccessibilityPostNotification(UIAccessibilityScreenChangedNotification,
[lastAdded routeFocusObject]);
} else if (layoutChanged) {
// TODO(goderbauer): figure out which node to focus next.
UIAccessibilityPostNotification(UIAccessibilityLayoutChangedNotification, nil);
Expand Down