This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Add diagnostics directory to the set of remote dirs #14470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miguelfrde could you please open an issue for moving the directories to a configurable location. Thanks for the contribution LGTM. |
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Dec 19, 2019
…flutter#14470)" This reverts commit 94654db.
iskakaushik
added a commit
that referenced
this pull request
Dec 19, 2019
miguelfrde
added a commit
to miguelfrde/engine
that referenced
this pull request
Jan 2, 2020
…ote dirs (flutter#14470)" (flutter#14566)" This reverts commit 4312d37. Once https://fuchsia-review.googlesource.com/c/topaz/+/351729 lands, the diagnostics directory will be present, this would be safe to do and the roller won't be blocked again.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…flutter#14470)" (flutter#14566) This reverts commit 94654db.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fuchsia component diagnostics team is changing the directory where inspect data lives to be in diagnostics.
As a side note, the proper fix of this I believe is to not hardcode these directories, but adding
diagnosticsfor now to unblock ourselves. Should I open an issue for that?