Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Shuffle test order and repeat test runs once. #12275

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Shuffle test order and repeat test runs once. #12275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shell/platform/embedder/tests/embedder_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ TEST_F(EmbedderTest, CanSpecifyCustomTaskRunner) {
kill_latch.Wait();

ASSERT_TRUE(signaled_once);
signaled_once = false;
}

TEST(EmbedderTestNoFixture, CanGetCurrentTimeInNanoseconds) {
Expand Down
25 changes: 15 additions & 10 deletions testing/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,39 +71,44 @@ def RunEngineExecutable(build_dir, executable_name, filter, flags=[], cwd=buildr
def RunCCTests(build_dir, filter):
print "Running Engine Unit-tests."

RunEngineExecutable(build_dir, 'client_wrapper_glfw_unittests', filter)
shuffle_flags = [
"--gtest_shuffle",
"--gtest_repeat=2",
]

RunEngineExecutable(build_dir, 'client_wrapper_glfw_unittests', filter, shuffle_flags)

RunEngineExecutable(build_dir, 'client_wrapper_unittests', filter)
RunEngineExecutable(build_dir, 'client_wrapper_unittests', filter, shuffle_flags)

# https://github.com/flutter/flutter/issues/36294
if not IsWindows():
RunEngineExecutable(build_dir, 'embedder_unittests', filter)
RunEngineExecutable(build_dir, 'embedder_unittests', filter, shuffle_flags)

flow_flags = ['--gtest_filter=-PerformanceOverlayLayer.Gold']
if IsLinux():
flow_flags = [
'--golden-dir=%s' % golden_dir,
'--font-file=%s' % roboto_font_path,
]
RunEngineExecutable(build_dir, 'flow_unittests', filter, flow_flags)
RunEngineExecutable(build_dir, 'flow_unittests', filter, flow_flags + shuffle_flags)

RunEngineExecutable(build_dir, 'fml_unittests', filter, [ time_sensitve_test_flag ])
RunEngineExecutable(build_dir, 'fml_unittests', filter, [ time_sensitve_test_flag ] + shuffle_flags)

RunEngineExecutable(build_dir, 'runtime_unittests', filter)
RunEngineExecutable(build_dir, 'runtime_unittests', filter, shuffle_flags)

# https://github.com/flutter/flutter/issues/36295
if not IsWindows():
RunEngineExecutable(build_dir, 'shell_unittests', filter)
RunEngineExecutable(build_dir, 'shell_unittests', filter, shuffle_flags)

RunEngineExecutable(build_dir, 'ui_unittests', filter)
RunEngineExecutable(build_dir, 'ui_unittests', filter, shuffle_flags)

# These unit-tests are Objective-C and can only run on Darwin.
if IsMac():
RunEngineExecutable(build_dir, 'flutter_channels_unittests', filter)
RunEngineExecutable(build_dir, 'flutter_channels_unittests', filter, shuffle_flags)

# https://github.com/flutter/flutter/issues/36296
if IsLinux():
RunEngineExecutable(build_dir, 'txt_unittests', filter, [ fonts_dir_flag ])
RunEngineExecutable(build_dir, 'txt_unittests', filter, [ fonts_dir_flag ] + shuffle_flags)


def RunEngineBenchmarks(build_dir, filter):
Expand Down