This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rolls engine to Android SDK 29 and its corresponding tools #10692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We need to land flutter/buildroot#294 so you can roll to that in this patch; my attempted fix last night didn't end up working, so rolling to the current ToT will break Windows again. |
Contributor
|
Looks like Javadoc is failing on this - does it pass locally? |
Author
|
@dnfield I also just noticed -- I forgot to make changes to two files from |
Author
|
I just made the changes, but we still need to wait for flutter/buildroot#294 to land and then roll the buildroot to that patch |
dnfield
approved these changes
Aug 7, 2019
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM
I think this is a better way to land it anyway, so that we can identify regressions independent of other changes. Thanks for doing this.
DEPS
Outdated
|
|
||
| deps = { | ||
| 'src': 'https://github.com/flutter/buildroot.git' + '@' + 'c6bd1f1e25048a97d99cf2fa679bd54ebad94697', | ||
| 'src': 'https://github.com/flutter/buildroot.git' + '@' + '07d0e2668a491a67197d569d4e6a724d3191bdd1', |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 7, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 7, 2019
[email protected]:flutter/engine.git/compare/dac86eb7fbf7...81f695f git log dac86eb..81f695f --no-merges --oneline 2019-08-07 [email protected] Roll src/third_party/dart f3139f57b4..f29f41f1a5 (3 commits) (flutter/engine#10693) 2019-08-07 [email protected] Roll buildroot forward to unbreak ToT (flutter/engine#10694) 2019-08-07 [email protected] Rolls engine to Android SDK 29 and its corresponding tools (flutter/engine#10692) 2019-08-07 [email protected] Fix empty composing range on iOS (flutter/engine#10381) 2019-08-07 [email protected] Roll src/third_party/skia ed19e97294f6..593290ed75fd (2 commits) (flutter/engine#10691) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Aug 16, 2019
…0692) * Rolls engine to Android SDK 29 and its corresponding tools * Update from android-28 to android-29 in relevant files * Roll buildroot to tip of tree
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the engine's Android SDK and tool versions to the buildroot's latest version. This unblocks the buildroot roll by updating the engine's Android SDK and related tools, since it may take some time before #10413 lands.
For all associated CIPD changes, see https://chrome-infra-packages.appspot.com/p/flutter/android/sdk