Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit f38b52b

Browse files
committed
Revert "turned on printing out the patch again (revert before landing)"
This reverts commit 6807bb6.
1 parent fa6dd6e commit f38b52b

File tree

1 file changed

+1
-22
lines changed

1 file changed

+1
-22
lines changed

ci/lint.sh

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,6 @@ DART="${DART_BIN}/dart"
3636
# to have this as an error.
3737
MAC_HOST_WARNINGS_AS_ERRORS="performance-move-const-arg,performance-unnecessary-value-param"
3838

39-
# FLUTTER_LINT_PRINT_FIX will make it so that fix is executed and the generated
40-
# diff is printed to stdout if clang-tidy fails. This is helpful for enabling
41-
# new lints.
42-
FLUTTER_LINT_PRINT_FIX=1
43-
if [[ -z "${FLUTTER_LINT_PRINT_FIX}" ]]; then
44-
fix_flag=""
45-
else
46-
fix_flag="--fix"
47-
fi
48-
4939
COMPILE_COMMANDS="$SRC_DIR/out/host_debug/compile_commands.json"
5040
if [ ! -f "$COMPILE_COMMANDS" ]; then
5141
(cd "$SRC_DIR"; ./flutter/tools/gn)
@@ -57,18 +47,7 @@ cd "$SCRIPT_DIR"
5747
"$SRC_DIR/flutter/tools/clang_tidy/bin/main.dart" \
5848
--src-dir="$SRC_DIR" \
5949
--mac-host-warnings-as-errors="$MAC_HOST_WARNINGS_AS_ERRORS" \
60-
$fix_flag \
61-
"$@" && true # errors ignored
62-
clang_tidy_return=$?
63-
if [ $clang_tidy_return -ne 0 ]; then
64-
if [ -n "$fix_flag" ]; then
65-
echo "###################################################"
66-
echo "# Attempted to fix issues with the following patch:"
67-
echo "###################################################"
68-
git --no-pager diff
69-
fi
70-
exit $clang_tidy_return
71-
fi
50+
"$@"
7251

7352
cd "$FLUTTER_DIR"
7453
pylint-2.7 --rcfile=.pylintrc \

0 commit comments

Comments
 (0)