another patch from the bot

Author: gaaclarke

impeller/aiks/aiks_unittests.cc

@@ -1726,8 +1726,8 @@ TEST_P(AiksTest, SaveLayerFiltersScaleWithTransform) {
   canvas.Translate(Vector2(100, 100));
 
   auto texture = std::make_shared<Image>(CreateTextureForFixture("boston.jpg"));
-  auto draw_image_layer = [&canvas, &texture](Paint paint) {
-    canvas.SaveLayer(std::move(paint));
+  auto draw_image_layer = [&canvas, &texture](const Paint& paint) {
+    canvas.SaveLayer(paint);
     canvas.DrawImage(texture, {}, Paint{});
     canvas.Restore();
   };

impeller/aiks/canvas.cc

@@ -206,13 +206,11 @@ void Canvas::DrawRRect(Rect rect, Scalar corner_radius, Paint paint) {
   if (AttemptDrawBlurredRRect(rect, corner_radius, paint)) {
     return;
   }
-  DrawPath(PathBuilder{}.AddRoundedRect(rect, corner_radius).TakePath(),
-           std::move(paint));
+  DrawPath(PathBuilder{}.AddRoundedRect(rect, corner_radius).TakePath(), paint);
 }
 
-void Canvas::DrawCircle(Point center, Scalar radius, Paint paint) {
-  DrawPath(PathBuilder{}.AddCircle(center, radius).TakePath(),
-           std::move(paint));
+void Canvas::DrawCircle(Point center, Scalar radius, const Paint& paint) {
+  DrawPath(PathBuilder{}.AddCircle(center, radius).TakePath(), paint);
 }
 
 void Canvas::ClipPath(const Path& path, Entity::ClipOperation clip_op) {
@@ -259,7 +257,7 @@ void Canvas::DrawPicture(Picture picture) {
 
 void Canvas::DrawImage(const std::shared_ptr<Image>& image,
                        Point offset,
-                       Paint paint,
+                       const Paint& paint,
                        SamplerDescriptor sampler) {
   if (!image) {
     return;
@@ -269,7 +267,7 @@ void Canvas::DrawImage(const std::shared_ptr<Image>& image,
   const auto dest =
       Rect::MakeXYWH(offset.x, offset.y, source.size.width, source.size.height);
 
-  DrawImageRect(image, source, dest, std::move(paint), std::move(sampler));
+  DrawImageRect(image, source, dest, paint, std::move(sampler));
 }
 
 void Canvas::DrawImageRect(const std::shared_ptr<Image>& image,

impeller/aiks/canvas.h

@@ -74,11 +74,11 @@ class Canvas {
 
   void DrawRRect(Rect rect, Scalar corner_radius, Paint paint);
 
-  void DrawCircle(Point center, Scalar radius, Paint paint);
+  void DrawCircle(Point center, Scalar radius, const Paint& paint);
 
   void DrawImage(const std::shared_ptr<Image>& image,
                  Point offset,
-                 Paint paint,
+                 const Paint& paint,
                  SamplerDescriptor sampler = {});
 
   void DrawImageRect(const std::shared_ptr<Image>& image,

impeller/display_list/display_list_dispatcher.cc

@@ -572,11 +572,11 @@ static std::optional<Paint::ImageFilterProc> ToImageFilterProc(
       auto sigma_y = Sigma(blur->sigma_y());
       auto tile_mode = ToTileMode(blur->tile_mode());
 
-      return [sigma_x, sigma_y, tile_mode](FilterInput::Ref input,
+      return [sigma_x, sigma_y, tile_mode](const FilterInput::Ref& input,
                                            const Matrix& effect_transform) {
         return FilterContents::MakeGaussianBlur(
-            std::move(input), sigma_x, sigma_y,
-            FilterContents::BlurStyle::kNormal, tile_mode, effect_transform);
+            input, sigma_x, sigma_y, FilterContents::BlurStyle::kNormal,
+            tile_mode, effect_transform);
       };
 
       break;
@@ -945,7 +945,7 @@ void DisplayListDispatcher::drawLine(const SkPoint& p0, const SkPoint& p1) {
   auto path = PathBuilder{}.AddLine(ToPoint(p0), ToPoint(p1)).TakePath();
   Paint paint = paint_;
   paint.style = Paint::Style::kStroke;
-  canvas_.DrawPath(path, std::move(paint));
+  canvas_.DrawPath(path, paint);
 }
 
 // |flutter::Dispatcher|
@@ -1230,7 +1230,7 @@ void DisplayListDispatcher::drawShadow(const SkPath& path,
     canvas_.DrawRRect(ToRect(rrect.rect()), rrect.getSimpleRadii().fX,
                       std::move(paint));
   } else {
-    canvas_.DrawPath(ToPath(path), std::move(paint));
+    canvas_.DrawPath(ToPath(path), paint);
   }
 
   canvas_.Restore();

impeller/entity/geometry.cc

@@ -19,11 +19,11 @@ Geometry::~Geometry() = default;
 // static
 std::unique_ptr<VerticesGeometry> Geometry::MakeVertices(
     const Vertices& vertices) {
-  return std::make_unique<VerticesGeometry>(std::move(vertices));
+  return std::make_unique<VerticesGeometry>(vertices);
 }
 
 std::unique_ptr<Geometry> Geometry::MakeFillPath(const Path& path) {
-  return std::make_unique<FillPathGeometry>(std::move(path));
+  return std::make_unique<FillPathGeometry>(path);
 }
 
 std::unique_ptr<Geometry> Geometry::MakeStrokePath(const Path& path,