Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit fa6dd6e

Browse files
committed
another patch from the bot
1 parent 6807bb6 commit fa6dd6e

File tree

5 files changed

+16
-18
lines changed

5 files changed

+16
-18
lines changed

impeller/aiks/aiks_unittests.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1726,8 +1726,8 @@ TEST_P(AiksTest, SaveLayerFiltersScaleWithTransform) {
17261726
canvas.Translate(Vector2(100, 100));
17271727

17281728
auto texture = std::make_shared<Image>(CreateTextureForFixture("boston.jpg"));
1729-
auto draw_image_layer = [&canvas, &texture](Paint paint) {
1730-
canvas.SaveLayer(std::move(paint));
1729+
auto draw_image_layer = [&canvas, &texture](const Paint& paint) {
1730+
canvas.SaveLayer(paint);
17311731
canvas.DrawImage(texture, {}, Paint{});
17321732
canvas.Restore();
17331733
};

impeller/aiks/canvas.cc

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -206,13 +206,11 @@ void Canvas::DrawRRect(Rect rect, Scalar corner_radius, Paint paint) {
206206
if (AttemptDrawBlurredRRect(rect, corner_radius, paint)) {
207207
return;
208208
}
209-
DrawPath(PathBuilder{}.AddRoundedRect(rect, corner_radius).TakePath(),
210-
std::move(paint));
209+
DrawPath(PathBuilder{}.AddRoundedRect(rect, corner_radius).TakePath(), paint);
211210
}
212211

213-
void Canvas::DrawCircle(Point center, Scalar radius, Paint paint) {
214-
DrawPath(PathBuilder{}.AddCircle(center, radius).TakePath(),
215-
std::move(paint));
212+
void Canvas::DrawCircle(Point center, Scalar radius, const Paint& paint) {
213+
DrawPath(PathBuilder{}.AddCircle(center, radius).TakePath(), paint);
216214
}
217215

218216
void Canvas::ClipPath(const Path& path, Entity::ClipOperation clip_op) {
@@ -259,7 +257,7 @@ void Canvas::DrawPicture(Picture picture) {
259257

260258
void Canvas::DrawImage(const std::shared_ptr<Image>& image,
261259
Point offset,
262-
Paint paint,
260+
const Paint& paint,
263261
SamplerDescriptor sampler) {
264262
if (!image) {
265263
return;
@@ -269,7 +267,7 @@ void Canvas::DrawImage(const std::shared_ptr<Image>& image,
269267
const auto dest =
270268
Rect::MakeXYWH(offset.x, offset.y, source.size.width, source.size.height);
271269

272-
DrawImageRect(image, source, dest, std::move(paint), std::move(sampler));
270+
DrawImageRect(image, source, dest, paint, std::move(sampler));
273271
}
274272

275273
void Canvas::DrawImageRect(const std::shared_ptr<Image>& image,

impeller/aiks/canvas.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,11 @@ class Canvas {
7474

7575
void DrawRRect(Rect rect, Scalar corner_radius, Paint paint);
7676

77-
void DrawCircle(Point center, Scalar radius, Paint paint);
77+
void DrawCircle(Point center, Scalar radius, const Paint& paint);
7878

7979
void DrawImage(const std::shared_ptr<Image>& image,
8080
Point offset,
81-
Paint paint,
81+
const Paint& paint,
8282
SamplerDescriptor sampler = {});
8383

8484
void DrawImageRect(const std::shared_ptr<Image>& image,

impeller/display_list/display_list_dispatcher.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -572,11 +572,11 @@ static std::optional<Paint::ImageFilterProc> ToImageFilterProc(
572572
auto sigma_y = Sigma(blur->sigma_y());
573573
auto tile_mode = ToTileMode(blur->tile_mode());
574574

575-
return [sigma_x, sigma_y, tile_mode](FilterInput::Ref input,
575+
return [sigma_x, sigma_y, tile_mode](const FilterInput::Ref& input,
576576
const Matrix& effect_transform) {
577577
return FilterContents::MakeGaussianBlur(
578-
std::move(input), sigma_x, sigma_y,
579-
FilterContents::BlurStyle::kNormal, tile_mode, effect_transform);
578+
input, sigma_x, sigma_y, FilterContents::BlurStyle::kNormal,
579+
tile_mode, effect_transform);
580580
};
581581

582582
break;
@@ -945,7 +945,7 @@ void DisplayListDispatcher::drawLine(const SkPoint& p0, const SkPoint& p1) {
945945
auto path = PathBuilder{}.AddLine(ToPoint(p0), ToPoint(p1)).TakePath();
946946
Paint paint = paint_;
947947
paint.style = Paint::Style::kStroke;
948-
canvas_.DrawPath(path, std::move(paint));
948+
canvas_.DrawPath(path, paint);
949949
}
950950

951951
// |flutter::Dispatcher|
@@ -1230,7 +1230,7 @@ void DisplayListDispatcher::drawShadow(const SkPath& path,
12301230
canvas_.DrawRRect(ToRect(rrect.rect()), rrect.getSimpleRadii().fX,
12311231
std::move(paint));
12321232
} else {
1233-
canvas_.DrawPath(ToPath(path), std::move(paint));
1233+
canvas_.DrawPath(ToPath(path), paint);
12341234
}
12351235

12361236
canvas_.Restore();

impeller/entity/geometry.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ Geometry::~Geometry() = default;
1919
// static
2020
std::unique_ptr<VerticesGeometry> Geometry::MakeVertices(
2121
const Vertices& vertices) {
22-
return std::make_unique<VerticesGeometry>(std::move(vertices));
22+
return std::make_unique<VerticesGeometry>(vertices);
2323
}
2424

2525
std::unique_ptr<Geometry> Geometry::MakeFillPath(const Path& path) {
26-
return std::make_unique<FillPathGeometry>(std::move(path));
26+
return std::make_unique<FillPathGeometry>(path);
2727
}
2828

2929
std::unique_ptr<Geometry> Geometry::MakeStrokePath(const Path& path,

0 commit comments

Comments
 (0)