Suppress MultisampledRenderToTextureBenchmark on Pixel2/GLES

jonahryandavis · Commit Bot · commit eb1df14b18a0 · 2020-10-01T21:26:23.000Z
This test started failing, but we don't care about performance on GLES so we can suppress it for now. Bug: angleproject:5120 Change-Id: If5eb865956ee5fb6f798d110d42e3493294bc18e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2443590 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
diff --git a/src/tests/perf_tests/MultisampledRenderToTexturePerf.cpp b/src/tests/perf_tests/MultisampledRenderToTexturePerf.cpp
@@ -106,6 +106,12 @@ MultisampledRenderToTextureBenchmark::MultisampledRenderToTextureBenchmark()
     {
         mSkipTest = true;
     }
+
+    // Fails on Pixel 2 GLES: http://anglebug.com/5120
+    if (IsPixel2() && GetParam().eglParameters.renderer == EGL_PLATFORM_ANGLE_TYPE_OPENGLES_ANGLE)
+    {
+        mSkipTest = true;
+    }
 }
 
 void MultisampledRenderToTextureBenchmark::initializeBenchmark()

Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,12 @@ MultisampledRenderToTextureBenchmark::MultisampledRenderToTextureBenchmark()`
`106`	`106`	`{`
`107`	`107`	`mSkipTest = true;`
`108`	`108`	`}`
	`109`	`+`
	`110`	`+ // Fails on Pixel 2 GLES: http://anglebug.com/5120`
	`111`	`+ if (IsPixel2() && GetParam().eglParameters.renderer == EGL_PLATFORM_ANGLE_TYPE_OPENGLES_ANGLE)`
	`112`	`+ {`
	`113`	`+ mSkipTest = true;`
	`114`	`+ }`
`109`	`115`	`}`
`110`	`116`
`111`	`117`	`void MultisampledRenderToTextureBenchmark::initializeBenchmark()`